allow firebase sdk v10 in peer deps #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Aug 3, 2023
jhuleatt
approved these changes
Aug 4, 2023
Collaborator
|
Thanks @austincrim! It looks like all the "custom" tests are failing - is that related to the changes in this PR?
|
Contributor
Author
|
@jhuleatt I'm not sure why only the custom tests are failing, my changes should not impact them in any way. I did notice the same tests are failing on my colleague's PR, maybe it's related to making a PR off of a fork? |
Collaborator
|
|
|
It is still an issue with firebase-tools v12.8.0 ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes firebase/firebase-tools#6109
Question: After we cut a new release, I thought we might need to bump the
FIREBASE_FRAMEWORKS_VERSIONconstant infirebase-tools, but since it has the^, it should download the newfirebase-frameworksversion right?