-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cloud_firestore] Add FieldPath #1296
[cloud_firestore] Add FieldPath #1296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests! It seems like we're relying on an implementation detail (the sentinel value is "__name__
") and instead I think we should implement it in the same way as FieldValue
and call the native version of FieldPath.documentId
.
…ybenot/flutterfire into firestore-field-path
@collinjackson What kind of formatter are you using in When I use the formatter (which the IDE does automatically 😞), the whole file is changed and the Cirrus CI test also fails.. It is very cumbersome for me to manually adjust the format. |
We're using Pro tip: The failure message gives you a patch command that will fix the formatting for you:
|
@collinjackson Thanks a bunch! |
I think that I am done with the new implementation. I added some exceptions that will help users understand what about their queries was incorrect and most importantly added assertions when possible. |
@collinjackson Can you review again? |
...e/android/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java
Outdated
Show resolved
Hide resolved
…ybenot/flutterfire into firestore-field-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this lgtm
Description
This brought my attention to
FieldPath
again. While my solution on StackOverflow works, it is not particularly nice to use.Related Issues
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?