Update firebase_auth version for release #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1526 added OAuth support to firebase_auth. I overlooked this in the review, but since this is adding new API surface area, it shouldn't be patch update -- it should at least be a minor update.
I thought about making it a breaking change since the Android
apidependency changed to 'com.google.firebase:firebase-auth:19.2.0': https://github.com/FirebaseExtended/flutterfire/pull/1526/files#diff-d8d76dca3eb1a8679bd5baa6e8b330c3We may want to move this to being an implementation dependency, see #39
We'll be bumping this plugin to 1.0 soon but I think we're not quite done making breaking changes yet.