From 9e51a366e7587b22448e81e16fcd024cf6ddbdcb Mon Sep 17 00:00:00 2001 From: Shashanka Nataraj Date: Wed, 8 Feb 2017 00:27:12 +0530 Subject: [PATCH 1/3] Removed unneeded inner `bind(this)` (#122) The inner bind is useless create-react-apps 'default webpack config was what pointed out this issue. --- examples/todoApp/js/todoAppFirebaseExplicit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/todoApp/js/todoAppFirebaseExplicit.js b/examples/todoApp/js/todoAppFirebaseExplicit.js index df65ce9d..eebe0294 100644 --- a/examples/todoApp/js/todoAppFirebaseExplicit.js +++ b/examples/todoApp/js/todoAppFirebaseExplicit.js @@ -32,7 +32,7 @@ var TodoApp2 = React.createClass({ var item = childSnapshot.val(); item['.key'] = childSnapshot.key; items.push(item); - }.bind(this)); + }); this.setState({ items: items From ae024361d9ca331a94be2d31eeb823e52051604f Mon Sep 17 00:00:00 2001 From: Edi Duluman Date: Mon, 13 Feb 2017 22:03:04 +0200 Subject: [PATCH 2/3] Cleaning up reference data when unbinding (#121) --- src/reactfire.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/reactfire.js b/src/reactfire.js index 600ce5b8..6a1c03e9 100644 --- a/src/reactfire.js +++ b/src/reactfire.js @@ -388,6 +388,7 @@ } delete this.firebaseRefs[bindVar]; delete this.firebaseListeners[bindVar]; + delete this.data[bindVar]; // Update state var newState = {}; From 420e7e5833528e80f5062e537030f88be93f1bc1 Mon Sep 17 00:00:00 2001 From: Jacob Wenger Date: Wed, 22 Feb 2017 11:03:42 -0800 Subject: [PATCH 3/3] Added version numbers to bower.json and package.json (#124) ### Description Catapult (the internal tool we use to release Firebase JavaScript libraries) now works without the `0.0.0` version placeholder in the `bower.json` and `package.json` files. So, we can finally add the actual version numbers back into these files. ### Code sample N/A --- bower.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bower.json b/bower.json index 743958d1..1a29735c 100644 --- a/bower.json +++ b/bower.json @@ -1,7 +1,7 @@ { "name": "reactfire", "description": "Firebase mixin for ReactJS", - "version": "0.0.0", + "version": "1.0.0", "authors": [ "Firebase (https://firebase.google.com/)" ], diff --git a/package.json b/package.json index c68e9858..cb4b1b01 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "reactfire", "description": "Firebase mixin for ReactJS", - "version": "0.0.0", + "version": "1.0.0", "author": "Firebase (https://firebase.google.com/)", "homepage": "https://github.com/firebase/reactfire/", "repository": {