Skip to content

Conversation

@ThariqS
Copy link
Contributor

@ThariqS ThariqS commented Apr 16, 2016

Tests and examples seem to work on my end.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ThariqS
Copy link
Contributor Author

ThariqS commented Apr 16, 2016

I signed it!

@jwngr
Copy link

jwngr commented Apr 18, 2016

Thanks for sending this along. You also need to update the bower.json dependency. Also, can you update the React version for all the examples in the /examples directory?

@googlebot
Copy link

CLAs look good, thanks!

@ThariqS
Copy link
Contributor Author

ThariqS commented Apr 19, 2016

Just added the bower.json and examples!

@deavial
Copy link

deavial commented Apr 22, 2016

any updates on when this will be pushed? thanks

@jwngr
Copy link

jwngr commented Apr 22, 2016

Looks good! Thanks for the contribution! I'll get a new version of ReactFire (0.7.0) out within the hour.

@jwngr jwngr merged commit 799b83f into FirebaseExtended:master Apr 22, 2016
@jwngr
Copy link

jwngr commented Apr 22, 2016

ReactFire 0.7.0 is out! Thanks again!

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants