Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enabling auto-enlistment should not disable system transactions. [DNET766] #708

Closed
firebird-issue-importer opened this issue May 28, 2017 · 4 comments

Comments

@firebird-issue-importer

Submitted by: Frédéric Delaporte (fredericdelaporte)

Jira_subtask_inward DNET791

It appears that when auto-enlistment is not enabled, explicit enlistment (FbConnection.EnlistTransaction) is disabled too.

The connection string parameter Enlist is normally only about enabling automatic enlistment at connection opening. It is not supposed to disable explicit enlistment.

Found while trying to get NHibernate transaction scope tests working with Firebird: rollback test fails even in a dedicated branch where I have added explicit enlistment. (I was hoping to be able to test that this way, since auto-enlistment breaks the NHibernate tests due to DNET764). Firebird .Net provider is the only provider tested by NHibernate which behaves in such a way.

Checked in the source, it looks like `Enlist` is not only used for auto-enlistment at connection opening, but also for globally disabling system transactions.
https://sourceforge.net/p/firebird/NETProvider/ci/master/tree/Provider/src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbConnectionInternal.cs#l282

Commits: 3ce7a82

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 16, 2017

Modified by: @cincuranet

Fix Version: vNextBig [ 10850 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 11, 2017

Modified by: @cincuranet

issuetype: Bug [ 1 ] => Sub-task [ 5 ]

Parent: DNET791 [ 21933 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 11, 2017

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 24, 2017

Commented by: Frédéric Delaporte (fredericdelaporte)

Thanks, tested with NHibernate test suit and 6.0.0-alpha2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants