Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C to cancel queries [CORE704] #1076

Closed
firebird-issue-importer opened this issue Apr 4, 2004 · 12 comments
Closed

Ctrl+C to cancel queries [CORE704] #1076

firebird-issue-importer opened this issue Apr 4, 2004 · 12 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Apr 4, 2004

Submitted by: @asfernandes

Is related to QA105

Attachments:
firebird-2.1.0.13360-isqlint.patch
firebird-2.1.0.13360-isqlint.patch

SFID: 929233#⁠
Submitted By: asfernandes

At this moment, pressing Ctrl+C in ISQL causes the
program termination.
Is more useful if Ctrl+C cancel the running query (i.e.
abort the output display).

Adriano.

Commits: ad4113e

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2006

Commented by: @mkubecek

Patch against 2.1.0.13360: if isql is interactive, SIGINT interrupts a query (only select). For non-interactive isql, program is terminated.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2006

Modified by: @mkubecek

Attachment: firebird-2.1.0.13360-isqlint.patch [ 10021 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2006

Commented by: @mkubecek

Fixed wrong initial value of Interrupt_flag.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2006

Modified by: @mkubecek

Attachment: firebird-2.1.0.13360-isqlint.patch [ 10022 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2006

Commented by: @asfernandes

Thanks Michal!
I'll write Windows code and commit together.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2006

Commented by: @asfernandes

Michal, at first glance I've think your patch is posix specific, but it works in Windows too.
But testing in Windows, second Ctrl+C causes process termination without entering in query_abort.
So I've changed it to call SetConsoleCtrlHandler returning appropriate value at query_abort and everything works correctly.

I do have only one comment, why remove "#⁠include <signal.h>"?
We use signal and SIGINT, should it really be removed?

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 25, 2006

Commented by: @mkubecek

It is not removed, it was included twice: once unconditionally and once depending on HAVE_SIGNAL_H. So I removed first #⁠include and left only the second (conditional).

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 26, 2006

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.1 [ 10041 ]

assignee: Dmitry Yemanov [ dimitr ]

SF_ID: 929233 =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jul 6, 2006

Modified by: @pcisar

assignee: Dmitry Yemanov [ dimitr ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 26, 2007

Modified by: @pcisar

Fix Version: 2.1 Alpha 1 [ 10150 ]

SF_ID: 929233 =>

Fix Version: 2.1.0 [ 10041 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 17, 2007

Modified by: @pcisar

Link: This issue is related to QA105 [ QA105 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 28, 2008

Modified by: @pcisar

Workflow: jira [ 10728 ] => Firebird [ 15103 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant