Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHEN <list of exceptions> tracks only the dependency on the first exception in PSQL. [CORE1165] #1588

Closed
firebird-issue-importer opened this issue Mar 12, 2007 · 12 comments

Comments

@firebird-issue-importer

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

Is related to QA76

The example is silly because I had to create the simplest test case to demonstrate a bug I found in the source code:

set term ^;

drop procedure p^
recreate exception e1 'e1'^
recreate exception e2 'e2'^
create procedure p as begin
begin end
when exception e1, exception e2 do begin end
end^
show depend p^
set term ;^

The output is

    \[P:Procedure\]

E1:Exception
+++

The output should be instead

    \[P:Procedure\]

E2:Exception, E1:Exception
+++

The proof of the bug is to issue:
recreate exception e1 'e1';
recreate exception e2 'e2';

after the script shown above. Recreating e1 fails due to dependencies but recreating e2 succeeds. With correct dependencies tracking, both should fail.
In the case of
drop exception e2;
the procedure will get a BLR error the next time it's run but after all clients disconnect from the db (due to procedure caching logic).

The problem is a copy/paste in the code from par_condition into par_conditions (note singular v/s plural).
The bug predates the FB project, as seen here:
http://firebird.cvs.sourceforge.net/firebird/interbase/jrd/par.c?revision=1.1&view=markup
It was inherited from IB.

(This message is being copy/pasted, too.)

Commits: c5a711e

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 12, 2007

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.1 [ 10041 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 15, 2007

Modified by: @pcisar

Version: 2.1.0 [ 10041 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 21, 2007

Commented by: @pcisar

Test added, but can't confirm the fix for 2.1 Alpha 1. Please change the fix version if this was fixed after Alpha 1, or reopen it.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 21, 2007

Commented by: @dyemanov

Set the fix version to Beta 1.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 21, 2007

Modified by: @dyemanov

Fix Version: 2.1 Beta 1 [ 10141 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 26, 2007

Modified by: @pcisar

Fix Version: 2.1.0 [ 10041 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 17, 2007

Modified by: @pcisar

Link: This issue is related to QA76 [ QA76 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 28, 2007

Commented by: @pcisar

Fix confirmed.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 28, 2007

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 28, 2008

Modified by: @pcisar

Workflow: jira [ 11690 ] => Firebird [ 15460 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2016

Modified by: @pavel-zotov

QA Status: No test

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2016

Modified by: @pavel-zotov

QA Status: No test => Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment