Wrong behaviour of services manager during backup/restore operations [CORE1232]

[firebird-issue-importer]

Submitted by: @AlexPeshkoff

When performing isc_action_svc_backup or isc_action_svc_restore, result of operation depends upon order of tags in clumplet, passed to SVC_start, and even backup may performed instead of restore. This may easily cause data loss.

Commits: 3a772ea

[firebird-issue-importer]

Commented by: @AlexPeshkoff

Order of tags in clumplet became much less important. The main restriction left is that to specify bkp/res size one must do it in exact order: filename1 size1 filename2 size2 filename_last. But this limitation looks more or less OK.

Tags for dbname and bkp_file may be used in any order, anyway what is given in dbname will be used for database, and what in bkp_file - for backup file name. Also when nothing of replace/create is given for restore operation, services manager defaults to create. Before this fix it was trying to do backup, which taken together with mixed order of dbname and bkp_file might cause backup file loss.

[firebird-issue-importer]

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.1 Beta 1 [ 10141 ]

[firebird-issue-importer]

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

[firebird-issue-importer]

Modified by: @pcisar

Workflow: jira [ 11954 ] => Firebird [ 15447 ]

[firebird-issue-importer]

Modified by: @pavel-zotov

QA Status: No test