Creation of invalid procedures/triggers allowed [CORE1271]

[firebird-automations]

Submitted by: @asfernandes

Is related to QA144

Dmitry reported that invalid procedures/triggers (with invalid plans, for example) was allowed to be created.
This is a regression of domains in PSQL code.

Commits: de7a981

[firebird-automations]

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

[firebird-automations]

Modified by: @pcisar

Link: This issue is related to QA144 [ QA144 ]

[firebird-automations]

Commented by: @pcisar

I have trouble to reproduce it with Alpha 1. Could you please provide a reproducible test case?

[firebird-automations]

Commented by: @asfernandes

He said:

The problem I have at hands is that CREATE/ALTER no longer cause the object to be compiled/optimized, thus everyone is now allowed to create invalid objects (containing wrong plans, ordering by blobs and other issues) without any warning (we have enough errors ignored by both the DSQL and PAR layers). While I have intentionally made the engine working this way for the restore process, I don't think it's good for the generic practice.

[firebird-automations]

Commented by: @dyemanov

I don't have Alpha 1 installed to verify the test case, but I think the following script should execute OK for Alpha 1 (what is wrong) and fail for Beta 1 (what is correct):

create procedure p returns (out int)
as
begin
for select rdb$relation_id
from rdb$relations
order by rdb$description
into :out
do
suspend;
end

commit;

[firebird-automations]

Modified by: @pcisar

Workflow: jira [ 12151 ] => Firebird [ 15374 ]

[firebird-automations]

Commented by: @pmakowski

Q/A tested ok

[firebird-automations]

Modified by: @pmakowski

status: Resolved [ 5 ] => Closed [ 6 ]

[firebird-automations]

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully