BUG in CsConvert::convert [CORE1594]

[firebird-automations]

Submitted by: @ibprovider

Attachments:
CsConvert.h

Wrong cycle of ignore trailing spaces
- uses end of temp_buffer instead of end of data in temp_buffer

See corrected source in attach

---
PS. I make small refactoring of this code :))

Commits: 82b13f3

[firebird-automations]

Modified by: @ibprovider

Attachment: CsConvert.h [ 10650 ]

[firebird-automations]

Modified by: @dyemanov

assignee: Adriano dos Santos Fernandes [ asfernandes ]

[firebird-automations]

Modified by: @asfernandes

Version: 2.1 Beta 1 [ 10141 ]

Version: 2.1 Alpha 1 [ 10150 ]

Fix Version: 2.1 RC1 [ 10201 ]

Version: 2.0.3 [ 10200 ] =>

[firebird-automations]

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

[firebird-automations]

Commented by: @AlexPeshkoff

Dmitry, please take into an account for the future - doing reinterpret_cast<const USHORT*>(UCHAR*) (or any other cast leading to stronger alignment requirements) is very dangerous. If original data is not aligned properly, it will break all RISC builds (like sparc, parisc).
I understand that doing development on machines where alignment is not 'must be' thing makes us forget about alignment issues, but please remember that firebird is also used on other CPUs.

[firebird-automations]

Commented by: @ibprovider

Alexander, I know about problems with bad-alignment by RISC machines. Thanks :)

And I know, also, than separation of generic "csconvert" on "csconvert_ucs2_to_mbc" and "csconvert_mbc_to_ucs2" can prevent this problems.

[firebird-automations]

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

[firebird-automations]

Modified by: @pcisar

Workflow: jira [ 13414 ] => Firebird [ 14073 ]

[firebird-automations]

Modified by: @pavel-zotov

QA Status: No test

[firebird-automations]

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested