-
-
Notifications
You must be signed in to change notification settings - Fork 233
BUG in CsConvert::convert [CORE1594] #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Modified by: @ibproviderAttachment: CsConvert.h [ 10650 ] |
Modified by: @dyemanovassignee: Adriano dos Santos Fernandes [ asfernandes ] |
Modified by: @asfernandesVersion: 2.1 Beta 1 [ 10141 ] Version: 2.1 Alpha 1 [ 10150 ] Fix Version: 2.1 RC1 [ 10201 ] Version: 2.0.3 [ 10200 ] => |
Commented by: @AlexPeshkoff Dmitry, please take into an account for the future - doing reinterpret_cast<const USHORT*>(UCHAR*) (or any other cast leading to stronger alignment requirements) is very dangerous. If original data is not aligned properly, it will break all RISC builds (like sparc, parisc). |
Commented by: @ibprovider Alexander, I know about problems with bad-alignment by RISC machines. Thanks :) And I know, also, than separation of generic "csconvert" on "csconvert_ucs2_to_mbc" and "csconvert_mbc_to_ucs2" can prevent this problems. |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Modified by: @pcisarWorkflow: jira [ 13414 ] => Firebird [ 14073 ] |
Modified by: @pavel-zotovQA Status: No test |
Modified by: @pavel-zotovstatus: Closed [ 6 ] => Closed [ 6 ] QA Status: No test => Cannot be tested |
Submitted by: @ibprovider
Attachments:
CsConvert.h
Wrong cycle of ignore trailing spaces
- uses end of temp_buffer instead of end of data in temp_buffer
See corrected source in attach
---
PS. I make small refactoring of this code :))
Commits: 82b13f3
The text was updated successfully, but these errors were encountered: