Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Submitted by: @ibprovider
Wrong cycle with scan of spaces
We must use count of converted (actual) bytes at temp_buffer
No a size of temp_buffer (CORE1594)
No a count of converted bytes (dest count). (CORETHIS_BUG)
Primary problem - using SINGLE local variable ' len ' for all cases:
1 - size of temp_buffer
2 - count of converted bytes from source into temp_buffer
3 - count of converted bytes in dest buffer.
On finish the "len" contaings the count of converted bytes IN DEST BUFFER.
But is used for scan of temp_buffer
Use 3 independent local variables and do scan FROM errPos TO count of bytes getted from second conversion (count of actually bytes in temp_buffer)
See attached source code in CORE1594
And just commit my changes.
I afraid, you can continue making a new bugs :)))
Latest changes in ChConvert.h (1.7) added new interesting bug - Now we, instead of buffer with UCS2 symbols of source string, scan the spaces at the left temp2 buffer.
Left buffer with left length :)))
Commits: f043833 608fa01 690a5ce
The text was updated successfully, but these errors were encountered:
assignee: Adriano dos Santos Fernandes [ asfernandes ]
Sorry, something went wrong.
Commented by: @asfernandes
This is not a competition for who can register more bugs.
Reopening the other one should be sufficient.
status: Open [ 1 ] => Resolved [ 5 ]
resolution: Fixed [ 1 ]
Fix Version: 2.1 RC1 [ 10201 ]
status: Resolved [ 5 ] => Closed [ 6 ]
Workflow: jira [ 13421 ] => Firebird [ 14071 ]
Commented by: @ibprovider
Corrections for CsConvert:convert
1. asserts before if-verification
2. using a 'len' before if-verification - temp.shrink(len / 2);
Attachment: CsConvert_1_14_diff.txt [ 11100 ]
Commented by: @dyemanov
Re-opened to apply (or reject) the attached corrections by Dmitry Kovalenko (see his recent comment).
status: Closed [ 6 ] => Reopened [ 4 ]
resolution: Fixed [ 1 ] =>
status: Reopened [ 4 ] => Resolved [ 5 ]
Fix Version: 2.1.2 [ 10270 ]
Fix Version: 2.5 Beta 1 [ 10251 ]
Adriano, Thank you very much!
QA Status: No test
status: Closed [ 6 ] => Closed [ 6 ]
QA Status: No test => Cannot be tested
Successfully merging a pull request may close this issue.