Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API change for efficient unprepare [CORE1741] #2164

Closed
firebird-issue-importer opened this issue Feb 12, 2008 · 5 comments
Closed

API change for efficient unprepare [CORE1741] #2164

firebird-issue-importer opened this issue Feb 12, 2008 · 5 comments

Comments

@firebird-issue-importer

Submitted by: Bill Oliver (verbguy)

Assigned to: Bill Oliver (verbguy)

SFID: 1469591#⁠
Submitted By: verbguy

We've added "efficient unprepare". The current API
isc_dsql_free_stmt() only supports DSQL_close (which
only closes a named cursor) and DSQL_drop (which
frees the statement handle). This change adds
DSQL_unprepare.

The api addition is:

#⁠define DSQL_close 1
#⁠define DSQL_drop 2
#⁠define DSQL_unprepare 4

Here is the code change for dsql/DStatement.cpp

ISC_STATUS DStatement::freeStatement(ISC_STATUS*
statusVector, int options)
{
ThreadData thread (statusVector, attachment);

try
{
if (options & (DSQL_close | DSQL_unprepare))
closeCursor();

if (options & (DSQL_drop | DSQL_unprepare))
{
closeStatement();
if (options & DSQL_drop)
delete this;
}
}
catch (OSRIException& exception)
{
return exception.copy (statusVector);
}

return 0;
}

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 12, 2008

Modified by: @dyemanov

issuetype: Bug [ 1 ] => Improvement [ 4 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 12, 2008

Modified by: @dyemanov

Workflow: jira [ 15635 ] => Firebird [ 15636 ]

Project: Vulcan [ 10001 ] => Firebird Core [ 10000 ]

Target: 2.5.0 [ 10221 ]

Key: VLC-26 => CORE1741

Planning Status: Included to release

Implementation: [Trivial]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 12, 2008

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 Alpha 1 [ 10224 ]

Development: Finished

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 12, 2009

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2016

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant