Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valgrind often reports "Conditional jump or move depends on uninitialised value(s)" in check_status_vector() [CORE1844] #2273

Closed
firebird-issue-importer opened this issue Apr 17, 2008 · 11 comments

Comments

@firebird-issue-importer

Submitted by: @AlexPeshkoff

When executing CREATE DATABASE from isql, valgrind reports:
==10931== Conditional jump or move depends on uninitialised value(s)
==10931== at 0x4BC0413: check_status_vector(long const*) (why.cpp:5229)
==10931== by 0x4BC22BB: (anonymous namespace)::Status::~Status() (why.cpp:801)
==10931== by 0x4BC2297: (anonymous namespace)::YEntry::~YEntry() (why.cpp:941)
==10931== by 0x4BB75FA: isc_attach_database (why.cpp:1376)
==10931== by 0x4D85869: PREPARSE_execute(long*, unsigned*, unsigned*, unsigned short, char const*, bool*, unsigned short) (preparse.cpp:254)
==10931== by 0x4BBAD67: isc_dsql_exec_immed2_m (why.cpp:2841)
==10931== by 0x4BBAA36: isc_dsql_exec_immed2 (why.cpp:2725)
==10931== by 0x4BBA82F: isc_dsql_execute_immediate (why.cpp:2676)
==10931== by 0x413E26: create_db(char const*, char*) (isql.cpp:4572)
==10931== by 0x4154DB: frontend(char const*) (isql.cpp:5395)
==10931== by 0x416EC7: get_statement(char*, unsigned long, char const*) (isql.cpp:6228)
==10931== by 0x4146EA: do_isql() (isql.cpp:4841)

Commits: e1f2751 365b9e1 a9fd3a9 7559d82

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 17, 2008

Modified by: @AlexPeshkoff

Version: 2.1 RC2 [ 10250 ]

Version: 2.5 Initial [ 10260 ]

Version: 2.1 RC1 [ 10201 ]

Version: 2.1 Beta 2 [ 10190 ]

Version: 2.0.3 [ 10200 ]

Version: 2.0.2 [ 10130 ]

Version: 2.1 Beta 1 [ 10141 ]

Version: 2.1 Alpha 1 [ 10150 ]

Version: 2.0.1 [ 10090 ]

Version: 2.0.0 [ 10091 ]

Version: 2.0.4 [ 10211 ]

Version: 2.1.0 [ 10041 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 17, 2008

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 17, 2008

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Open [ 1 ]

Target: 2.5 Alpha 1, 2.1.1, 2.0.5 [ 10224, 10223, 10222 ]

Fix Version: 2.0.5 [ 10222 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 17, 2008

Modified by: @AlexPeshkoff

Fix Version: 2.0.5 [ 10222 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 17, 2008

Commented by: @AlexPeshkoff

All error codes are defined as ISC_LONG
(32bit) in iberror.h. But they are stored in status vector, which is
ISC_STATUS (64 bit). Everything is not too bad as long as there is only one
error code in a vector - it's passed as first parameter in
ERR_post(ISC_STATUS, ...), and compiler knows it must convert it to 64-bit
value. But if some more error code is passed, it's passed as vararg,
therefore no conversion takes place. And 4 high bytes of ISC_STATUS contain
dirt (I've seen myself that it may be non-zero).

Datatypes should better match!

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 17, 2008

Modified by: @AlexPeshkoff

Fix Version: 2.5 Alpha 1 [ 10224 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 6, 2008

Modified by: @AlexPeshkoff

Fix Version: 2.1.1 [ 10223 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 22, 2008

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.0.5 [ 10222 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 18, 2008

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2016

Modified by: @pavel-zotov

QA Status: No test

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 22, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment