Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isql's extracted script is unusable with interdependent selectable procedures in FB 2.1 [CORE1862] #2292

Closed
firebird-issue-importer opened this issue Apr 24, 2008 · 6 comments

Comments

@firebird-issue-importer

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

Is related to QA343

Since IB6 or before (can't remember) isql has extracted first the procedure's headers (parameters) and later the bodies. It typically does:
CREATE PROCEDURE P AS
BEGIN EXIT; END ^

However, as FB2.1 has a way to distinguish between selectable and executable procedures and enforces the difference, if a proc A that calls a selectable proc B is defined before B, A won't compile because (due to the header) FB knows it's not selectable.
The solution is that for FB2.1 and newer, isql read the rdb$procedure_type field and do the correct header extraction as shown here:
CREATE PROCEDURE P AS
BEGIN SUSPEND; END ^

Commits: dec27dc d3e036d

====== Test Details ======

Sent letter to dimitr 08.03.2018 00:38, waiting for reply.
One more letter, sent to adriano and dimitr, 28.01.2020 20:39. Waiting for reply.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 24, 2008

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 12, 2008

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 Alpha 1 [ 10224 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 23, 2011

Modified by: @pcisar

Link: This issue is related to QA343 [ QA343 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2016

Modified by: @pavel-zotov

QA Status: No test

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 8, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

Test Details: Sent letter to dimitr 08.03.2018 00:38, waiting for reply.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 28, 2020

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

Test Details: Sent letter to dimitr 08.03.2018 00:38, waiting for reply. => Sent letter to dimitr 08.03.2018 00:38, waiting for reply.
One more letter, sent to adriano and dimitr, 28.01.2020 20:39. Waiting for reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant