Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash sign (#) in filenames in aliases.conf not handled correctly [CORE1905] #2336

Closed
firebird-issue-importer opened this issue May 18, 2008 · 7 comments

Comments

@firebird-issue-importer

Submitted by: Stefan Heymann (stefanheymann)

Assigned to: Claudio Valderrama C. (robocop)

For whatever reason, a customer wanted to have his database in a directory which contained a Hash character (#⁠) in its name.

So the entry in aliases.conf looked like this

mydb = D:\#⁠kit\subdir\mydatabase.fdb

The hash sign, however, starts a comment in aliases.conf. We could only work around that by selecting another directory (which can be
difficult when you have fixed naming conventions on a customer server).

Quoting the database filename doesn't help in Firebird 1.5.5. It just changes the error message when you try to create that database.

I also did a test with Firebird 2.1 with a quoted filename:

mydb = "D:\#⁠kit\subdir\mydatabase.fdb"

With the above alias string, when I do a CREATE DATABASE, a file named MYDB (the name of the alias, without any extension) is created in the Firebird\bin (!) directory.

So there seems to be a problem with hash signs in alias filenames. I know this seems to be a rare case, but you can never know what crazy path naming conventions you find on customer's systems ...

Commits: a520a47

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 19, 2008

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 19, 2008

Commented by: Claudio Valderrama C. (robocop)

I will try to fix the logic only for aliases.conf

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 19, 2008

Commented by: @dyemanov

IMHO, the correct solution would be to add support for double quotes in the right (value) part and treat the quoted string as a single entity.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 19, 2008

Commented by: Stefan Heymann (stefanheymann)

There already seems to be a kind of double quote support as Firebird 2.1 behaves differently than 1.5.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 12, 2008

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 Alpha 1 [ 10224 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 12, 2009

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2016

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant