Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"instsvc remove" returns 1 when succefully executed [CORE1923] #2357

Closed
firebird-issue-importer opened this issue Jun 6, 2008 · 11 comments
Closed

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Jun 6, 2008

Submitted by: Gregory Kotsaftis (gregkotsaftis)

When we SUCCESSFULLY execute "instsvc remove", part of firebird uninstallation, the command returns errorlevel 1.
This way our uninstallation script assumes the command has failed and fails.
The "instsvc remove" displays: Service "Firebird Server - DefaultInstance" successfully deleted.

instsvc stop, (called before remove)
and
instreg remove, (called after remove)

are successfully executed.

This did not happen in 1.5 releases.

Commits: d4ea28e 7bec52f 872a100

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 6, 2008

Commented by: @dyemanov

Am I right that it happens only when you setup the server *without* the guardian?

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 6, 2008

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 7, 2008

Commented by: Gregory Kotsaftis (gregkotsaftis)

I do not use the neither the guardian nor the setup file for windows.
I just use the ZIP firebird installation, unzip it and manually call instsvc and instreg to install and uninstall the service.
Hope this helps...

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 22, 2009

Commented by: Gregory Kotsaftis (gregkotsaftis)

Hi, I think I found the root of this problem.
It is found in "install_svc.cpp", line: 389

if (status != FB_SUCCESS && status2 != FB_SUCCESS)
status = FB_FAILURE;

This results to error if there is no Guardian installed to be removed (status).

Can someone verify this because my C++ knowledge is at least 15 years rusty...

Greg--

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 23, 2009

Modified by: @dyemanov

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 7, 2009

Modified by: @dyemanov

status: In Progress [ 3 ] => Open [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 7, 2009

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 Beta 1 [ 10251 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 9, 2009

Modified by: @dyemanov

Fix Version: 2.1.3 [ 10302 ]

Fix Version: 2.0.6 [ 10303 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 8, 2009

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2016

Modified by: @pavel-zotov

QA Status: No test

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 12, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants