Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible AV in engine if procedure was altered to have no outputs and dependent procedures was not recompiled [CORE1930] #2365

Closed
firebird-issue-importer opened this issue Jun 10, 2008 · 10 comments

Comments

@firebird-issue-importer

Submitted by: @hvlad

Is related to QA217

Commits: 1127cf6 9736166 394eca2

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 10, 2008

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 10, 2008

Commented by: @hvlad

Test case :

create or alter procedure sp1 returns (x int)
as
begin
suspend;
end

create or alter procedure sp2
as
declare x int;
begin
select x from sp1 into :x;
end

create or alter procedure sp3
as
begin
execute procedure sp2;
end

commit

-- this is wrong but engine still didn't track procedure's fields dependencies
create or alter procedure sp1
as
begin
exit;
end

commit

-- disconnect and connect again

create or alter procedure sp3
as
begin
execute procedure sp2;
end

commit

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 10, 2008

Modified by: @hvlad

Fix Version: 2.5 Alpha 1 [ 10224 ]

Fix Version: 2.1.2 [ 10270 ]

Fix Version: 2.0.5 [ 10222 ]

summary: AV in engine when procedure was altered to have no outputs and dependent procedures was not recompiled => Possible AV in engine if procedure was altered to have no outputs and dependent procedures was not recompiled

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 10, 2008

Commented by: @hvlad

FB 2.1 on ODS 11.1 and higher raised error on commit :

Invalid token.
invalid request BLR at offset 32.
Procedure SP1 is not selectable (it does not contain a SUSPEND statement).

but on older ODS it crashes

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 10, 2008

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 26, 2008

Modified by: @pcisar

Link: This issue block progress on QA217 [ QA217 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 26, 2009

Modified by: @pcisar

Link: This issue is related to QA217 [ QA217 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 26, 2009

Modified by: @pcisar

Link: This issue block progress on QA217 [ QA217 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 25, 2011

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 27, 2015

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment