Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the Hostname in mon$attachments [CORE2187] #2617

Closed
firebird-issue-importer opened this issue Nov 13, 2008 · 16 comments
Closed

Return the Hostname in mon$attachments [CORE2187] #2617

firebird-issue-importer opened this issue Nov 13, 2008 · 16 comments

Comments

@firebird-issue-importer

Submitted by: @WarmBooter

Is related to QA636
Block progress on DNET652

Votes: 1

Add a new column to mon$attachments containg the Hostname of the client. Not sure if Hostname can be returned when protocol is not TCPIP, in this case, maybe it should return null.

Commits: 9f2a992

====== Test Details ======

Reference to 'MON$REMOTE_HOST' is used in core_4135.fbt

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 14, 2008

Commented by: @AlexPeshkoff

One minor issue with adding hostname column - it will require reverse DNS lookup, which may be slow sometimes. Certainly, in case when it's a problem one can not put this field in select list, but I already see an isssue in this tracker: after execute of 'SELECT * FROM MON$ATTACHMENTS' server sometimes hangs for a long time.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 14, 2008

Commented by: @dyemanov

It doesn't make any difference, whether this field is specified in the select list or not. All the fields are filled always, thus the DNS lookup will happen anyway, so there's no workaround.

Personally, I'd rather prefer to see this feature implemented either by a customer's UDF or at the client side (by a monitoring application or whatever).

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 14, 2008

Commented by: @AlexPeshkoff

May be add such UDF to fb_udf library?

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 14, 2008

Commented by: @WarmBooter

I agree that if there is a chance to make things slower, this feature should not be implemented as an internal field. In this case, Alex UDF proposal looks good, specially if it is included in fb_udf, as he suggested.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 14, 2008

Commented by: @hvlad

I vote that fbclient passed host name, fbclient version etc
For older fbclient there will be NULL's in MON$ATTACHMENTS

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 14, 2008

Commented by: @AlexPeshkoff

Vlad suggestion has one serious plus - it will work not only for TCP/IP, but also for PC/LAN. On the other hand, resolving host name via IP address is client-independent. And I do not think that this approachs exclude one another - we mat add field passed by fbclient and also add an UDF, that will invoke OS name resolver.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 15, 2008

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 15, 2008

Modified by: @dyemanov

status: Open [ 1 ] => Open [ 1 ]

Fix Version: 3.0 Initial [ 10301 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 29, 2009

Modified by: @dyemanov

Fix Version: 3.0 Alpha 1 [ 10331 ]

Fix Version: 3.0 Initial [ 10301 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 11, 2012

Modified by: @dyemanov

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 12, 2012

Modified by: @dyemanov

status: In Progress [ 3 ] => Open [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 12, 2012

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 28, 2015

Modified by: @pcisar

Link: This issue is related to QA636 [ QA636 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 19, 2016

Modified by: @pavel-zotov

QA Status: No test

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 12, 2016

Modified by: @cincuranet

Link: This issue block progress on DNET652 [ DNET652 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Aug 22, 2016

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Covered by another test(s)

Test Details: Reference to 'MON$REMOTE_HOST' is used in core_4135.fbt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment