*round UDFs broken for negative numbers [CORE2281]

[firebird-issue-importer]

Submitted by: @paulvink

Assigned to: Claudio Valderrama C. (robocop)

Anything on <-0.6, 0] rounds to 0
Anything on <-1, -0.6] rounds to +1
Anything on <-1.6, -1] rounds to -1
Anything on <-2.6, -1.6] rounds to -2
Anything on <-3.6, -2.6] rounds to -3
and so on

Commits: b2b178f 57ed00d 89fdae4 bc2e065

[firebird-issue-importer]

Commented by: Claudio Valderrama C. (robocop)

Since this problem was reported privately by Paul Vinkenoog privately to me months ago but I didn't have time to fix it until recently and he put the tracker item when I showed it a change fbudf, I'm going to commit the same code in all affected branches. Not necessarily what Paul wanted, since round and trunc in fbudf were mean to be asymmetric like in the math definition (unlike Delphi functions).
round always rounds to the next bigger integer when it's in the upper half of the range (including x.5).
trunc always truncates to the biggest integer that's equal or smaller than the argument.

[firebird-issue-importer]

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

[firebird-issue-importer]

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 Beta 1 [ 10251 ]

[firebird-issue-importer]

Modified by: Claudio Valderrama C. (robocop)

Fix Version: 2.1.2 [ 10270 ]

Fix Version: 1.5.6 [ 10225 ]

Fix Version: 2.0.6 [ 10303 ]

[firebird-issue-importer]

Modified by: @dyemanov

Fix Version: 2.1.3 [ 10302 ]

Fix Version: 2.1.2 [ 10270 ] =>

[firebird-issue-importer]

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

[firebird-issue-importer]

Modified by: @pavel-zotov

QA Status: No test