Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of several validations in gbak [CORE2545] #2955

Closed
firebird-issue-importer opened this issue Jul 7, 2009 · 6 comments
Closed

Lack of several validations in gbak [CORE2545] #2955

firebird-issue-importer opened this issue Jul 7, 2009 · 6 comments

Comments

@firebird-issue-importer
Copy link

firebird-issue-importer commented Jul 7, 2009

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

Not very useful to the end user:
gbak ,
gbak: ERROR:Firebird::string - pos out of range

Undocumented skip (used for damaged backups) accepts negative offsets. When running as a service, it may trash the server.

It's possible to overflow the backup sizes just for fun, using large numbers plus G (giga).

Etc.

Commits: 08a33d5

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 7, 2009

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 27, 2009

Commented by: Claudio Valderrama C. (robocop)

SKIP is not really a problem: it's covered by code that converts invalid input into zero.
Backup sizes for multi-file backup is an undetected problem since the size is limited to ULONG but it's unchecked.
Also, several backup options can be applied to restore and several restore options can be applied to backup (nonsense).

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 27, 2009

Commented by: Claudio Valderrama C. (robocop)

NT and T can be applied simultaneously (the last one processed by the parsing logix wins).
Several options that have parameters can be specified many times, with different parameter values. For example, -fa 1 - fa 10 for backup. Again, the last one seen by the parsing logic is the winner.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 6, 2009

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 14, 2011

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment