Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make memory and other statistics to work with 64-bit values [CORE2619] #3029

Closed
firebird-issue-importer opened this issue Sep 6, 2009 · 7 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Sep 6, 2009

Submitted by: @hvlad

Commits: 45bbbe0 0396da5 f8c417a 46a72fc

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 6, 2009

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 6, 2009

Modified by: @dyemanov

summary: Make memory and other stastics works with 64-bit values => Make memory and other statistics to work with 64-bit values

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 9, 2009

Commented by: @hvlad

There are two parts of the issue :
a) make engine to use 64-bit integers for statistics
b) teach tools (isql and qli) to work with 64-bit values

a) we need to change internals of AtomicCounter to use 64-bit values
On Win64 we will use InterlockedXXX64 functions while on Win32 it is enough to continue usage of InterlockedXXX
For POSIX platforms i already asked Alex about its implementation of AtomicCounter

b) to report statistics, isql\qli used perf_xxx functions imported from fbclient. This functions works with
"struct perf" which used platform-dependent "long" data type. As we want 32-bit isql to work correctly
with 64-bit server we need to always use 64-bit values within "perf". To not change (not so) public API, i
will introduce new "struct perf64" and perf64_xxx functions and change isql and qli to use this new API.
Note, this will make isql and qli not compatible with older fbclient. This is not a first time, so i see no problem there.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 30, 2009

Modified by: @hvlad

Fix Version: 2.5 RC1 [ 10362 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 1, 2009

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 12, 2009

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants