Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isql extracts the array dimensions after the character set name [CORE2788] #3179

Closed
firebird-issue-importer opened this issue Dec 2, 2009 · 5 comments

Comments

@firebird-issue-importer
Copy link

firebird-issue-importer commented Dec 2, 2009

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

First, we try to put the dimension after the character set. The server rejects the syntax, then we put the array indication before the character set and succeed:

F:\fb3dev\fbbuild\firebird30\temp\Win32\Debug\firebird\bin>isql
Use CONNECT or CREATE DATABASE to specify a database
SQL> create database 'domain.fdb';
SQL> create domain d as char(1) character set iso8859_1[1:2];
Statement failed, SQLSTATE = 42000
Dynamic SQL Error
-SQL error code = -104
-Token unknown - line 1, column 51
-[
SQL> create domain d as char(1)[1:2] character set iso8859_1;
SQL> ^Z

But isql extracts the array dimensions after the character set, rendering the script not syntax compliant:

F:\fb3dev\fbbuild\firebird30\temp\Win32\Debug\firebird\bin>isql -x DOMAIN.FDB
Database: DOMAIN.FDB

SET SQL DIALECT 3;

/* CREATE DATABASE 'DOMAIN.FDB' PAGE_SIZE 4096 DEFAULT CHARACTER SET NONE; */

/* Domain definitions */
CREATE DOMAIN D AS CHAR(1) CHARACTER SET ISO8859_1[2];

It seems the bug is rather ancient, but I only tested FB3, FB2.5 and FB2.0.

Commits: 6d1781b

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 2, 2009

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 3, 2009

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 14, 2011

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

QA Status: No test

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 29, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment