Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server crashes while restoring a database having an expression index referencing a non-existent UDF [CORE2914] #3298

Closed
firebird-issue-importer opened this issue Mar 9, 2010 · 8 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Mar 9, 2010

Submitted by: @dyemanov

In the past, the engine has been made "smart enough" to not interrupt the restore process if some UDF library is missing. Instead, GBAK prints a warning and the process continues. But if some expression index references the missing UDF, the engine crashes while trying to call that UDF while creating the index.

We could throw an error and terminate the restore process in this case. Another alternative would be to restore such an index as inactive, with an appropriate message printed into stderr.

Commits: eadb960 e26e17c dc92d8e

====== Test Details ======

Log of fbt_run:

E
ERROR: bugs.core_2914
Database restore
Unexpected stderr stream received from GBAK.

-- looks like the database can`t be restored.

But this message happens ONLY inside fbt_run, because gbak itself DOES finish of restoring process!
Command:
gbak.exe -rep core2914-ods12.fbk host/port:path\tmp2914.fdb -v 1>log 2>err

-- produces file `err'` with ZERO size (empty) and `log`with mesages:

. . .
gbak: restoring privilege for user SYSDBA
gbak:creating indexes
gbak: activating and creating deferred index TEST_X_REVERSE
gbak:cannot commit index TEST_X_REVERSE
gbak: ERROR:function ID_REVERSE is not defined
gbak: ERROR: module name or entrypoint could not be found
gbak: ERROR: function ID_REVERSE is not defined
gbak: ERROR: module name or entrypoint could not be found
gbak:committing metadata
gbak:fixing views dbkey length
gbak:updating ownership of packages, procedures and tables
gbak:adding missing privileges
gbak:fixing system generators
gbak:finishing, closing, and going home <<<<<<<<<<<<<<<<<<<<<<<<<<<<< !! OK !! <<<<<<<<<<<<<<<<<
gbak:adjusting the ONLINE and FORCED WRITES flags

Wait for reply from dimitr on letter about problem with restoring .fbk under fbt-run, date: 14-may-2015 22:41.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 9, 2010

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 9, 2010

Modified by: @dyemanov

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 9, 2010

Commented by: Andrei Kireev (andreik)

I would vote for second option.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 10, 2010

Modified by: @dyemanov

status: In Progress [ 3 ] => Open [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 10, 2010

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 RC3 [ 10381 ]

Fix Version: 2.1.4 [ 10361 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 4, 2011

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 26, 2015

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Not enough information

Test Details: Wait for reply from dimitr on letter about problem with restoring .fbk under fbt-run, date: 14-may-2015 22:41.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 27, 2015

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

Test Details: Wait for reply from dimitr on letter about problem with restoring .fbk under fbt-run, date: 14-may-2015 22:41. => Log of fbt_run:

E
ERROR: bugs.core_2914
Database restore
Unexpected stderr stream received from GBAK.

-- looks like the database can`t be restored.

But this message happens ONLY inside fbt_run, because gbak itself DOES finish of restoring process!
Command:
gbak.exe -rep core2914-ods12.fbk host/port:path\tmp2914.fdb -v 1>log 2>err

-- produces file `err'` with ZERO size (empty) and `log`with mesages:

. . .
gbak: restoring privilege for user SYSDBA
gbak:creating indexes
gbak: activating and creating deferred index TEST_X_REVERSE
gbak:cannot commit index TEST_X_REVERSE
gbak: ERROR:function ID_REVERSE is not defined
gbak: ERROR: module name or entrypoint could not be found
gbak: ERROR: function ID_REVERSE is not defined
gbak: ERROR: module name or entrypoint could not be found
gbak:committing metadata
gbak:fixing views dbkey length
gbak:updating ownership of packages, procedures and tables
gbak:adding missing privileges
gbak:fixing system generators
gbak:finishing, closing, and going home <<<<<<<<<<<<<<<<<<<<<<<<<<<<< !! OK !! <<<<<<<<<<<<<<<<<
gbak:adjusting the ONLINE and FORCED WRITES flags

Wait for reply from dimitr on letter about problem with restoring .fbk under fbt-run, date: 14-may-2015 22:41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment