Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to drop non-existing generator produces bad error [CORE3114] #3492

Closed
firebird-issue-importer opened this issue Aug 22, 2010 · 11 comments

Comments

@firebird-issue-importer

Submitted by: @aafemt

Attachments:
dyn_del.diff
CORE-3114.zip

Attempt to drop not existing generator produces isc_random error that makes the error hard to recognize and also has other disadvantages, such as ignoring client locale.

Commits: e090671

====== Test Details ======

Can`t reproduce on:
WI-V2.0.6.13266
WI-V2.1.3.18185

SQL> set heading off; set term ^; execute block returns(e int) as begin execute statement 'drop sequence tratata'; when any do begin
e=gdscode; suspend; end end^ set term ;^

335544351 // it's not isc_random = 335544382

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 22, 2010

Commented by: @aafemt

Proposed patch.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 22, 2010

Modified by: @aafemt

Attachment: dyn_del.diff [ 11710 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 22, 2010

Commented by: @hvlad

It seems to me that the real issue is that DYN_error() don't put real error code into status-vector but isc_random + interpreted string instead.
I don't understand why it is written in this way.

Regarding your patch - it is not good idea to "fix" one particular case of more generic problem.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 22, 2010

Commented by: @aafemt

Step by step, Vlad. Now I care only about dropping of generators. More generic problem belongs to CORE3112. Reworking half of the engine is too much for one ticket.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 22, 2010

Commented by: @hvlad

DYN_error() is not a half of the engine.
We don't need more spagetty code than we already have (in some places).
If you want to do something really useful - look at general issue, not at small part of it.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 29, 2010

Commented by: @aafemt

Better patch for HEAD only.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 29, 2010

Modified by: @aafemt

Attachment: CORE3114.zip [ 11740 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 9, 2011

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 29, 2014

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

QA Status: No test

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 16, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Deferred

Test Details: Can`t reproduce on:
WI-V2.0.6.13266
WI-V2.1.3.18185

SQL> set heading off; set term ^; execute block returns(e int) as begin execute statement 'drop sequence tratata'; when any do begin
e=gdscode; suspend; end end^ set term ;^

335544351 // it's not isc_random = 335544382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment