Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of backup volumes with size more than 4Gb [CORE3575] #3929

Closed
firebird-issue-importer opened this issue Aug 17, 2011 · 8 comments
Closed

Comments

@firebird-issue-importer

Submitted by: @alexeykovyazin

There is a bug in gbak implementation of backup process with volumes.
According to Firebird implementation, it should be not possible to create volume of backup with explicitly specified size which is more than 4gb.
Bug is in the following behaviour - if there will be set size which more than 4Gb and reminder of its division by 4 is not 0, backup volume will be created with remainder's size.
Example:
gbak -b -user SYSDBA -pass masterkey database.fdb vol1.fbk 41g vol2.fbk

vol1.fbk will be 1Gb in size, and rest is in vol2.fbk.

What should be done:
1) Wrong behaviour should be fixed (probably backported?) so it should not be possible to specify more than 4Gb size
2) In the future version implement support of bigger volumes, because 4Gb is obviously outdated limitation.

Commits: 6822569

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 17, 2011

Commented by: @alexeykovyazin

Details on implementation:
class burp_fil
{
public:
burp_fil* fil_next;
Firebird::PathName fil_name;
ULONG fil_length; <<< !!!!

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 17, 2011

Modified by: @alexeykovyazin

description: There is a bug in gbak implementation of backup process with volumes.
According to Firebird implementation, it sgould be not possible to create volume of backup with explicitly specified size which is more than 4gb.
Bug is in the following behaviour - if there will be set size which more than 4Gb and reminder of its division by 4 is not 0, backup volume will be created with remainder's size.
Example:
gbak -b -user SYSDBA -pass masterkey database.fdb vol1.fbk 41g vol2.fbk

vol1.fbk will be 1Gb in size, and rest is in vol2.fbk.

What should be done:
1) Wrong behaviour should be fixed (probably backported?) so it should not be possible to specify more than 4Gb size
2) In the future version implement support of bigger volumes, because 4Gb is obviously outdated limitation.

=>

There is a bug in gbak implementation of backup process with volumes.
According to Firebird implementation, it should be not possible to create volume of backup with explicitly specified size which is more than 4gb.
Bug is in the following behaviour - if there will be set size which more than 4Gb and reminder of its division by 4 is not 0, backup volume will be created with remainder's size.
Example:
gbak -b -user SYSDBA -pass masterkey database.fdb vol1.fbk 41g vol2.fbk

vol1.fbk will be 1Gb in size, and rest is in vol2.fbk.

What should be done:
1) Wrong behaviour should be fixed (probably backported?) so it should not be possible to specify more than 4Gb size
2) In the future version implement support of bigger volumes, because 4Gb is obviously outdated limitation.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 17, 2011

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 5, 2013

Commented by: @AlexPeshkoff

What about 2.5 - check avoiding overflow of 4Gb limit is already present and works correctly in B2_5.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 5, 2013

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Apr 23, 2013

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

QA Status: No test

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 20, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants