Support for sweep information in Trace API [CORE3656]

[firebird-automations]

Submitted by: Thomas Steinmaurer (tsteinmaurer)

Relate to DNET451

Votes: 1

Currently, the Trace API doesn't have any support for generating trace events when a sweep happens (starts/finishes). In the trace output, there should be a way to distinguish between a sweep, which has been triggered automatically (due to the sweep interval) and a sweep, which was invoked by the user manually.

Commits: b636315 8dc7b56 9124f5e 0b46626 53fc571 4f9a670

====== Test Details ======

See tests for CORE4337 and CORE3934

[firebird-automations]

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

[firebird-automations]

Modified by: @dyemanov

Fix Version: 2.5.2 [ 10450 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

[firebird-automations]

Commented by: @hvlad

Improvement is committed into v2.5.2, v3 will follow soon

[firebird-automations]

Commented by: @hvlad

A documentation.

1. Trace configuration have new parameter (see fbtrace.conf)

#⁠ Sweep activity
#⁠log\_sweep false

2. Four new events related to sweep activity was introduced at the trace output:

a) SWEEP_START - when sweep process is started
Prints usual attachment info and transaction counters at the sweep start moment:

2012-06-26T14:17:28.1380 (3408:03828510) SWEEP_START
EMPLOYEE.FDB (ATT_15285, SYSDBA:NONE, NONE, XNET:W2K3-X64)
firebird\bin\gfix.exe:3516

Transactions counters:
Oldest interesting 29418
Oldest active 29419
Oldest snapshot 29419
Next transaction 29421

b) SWEEP_FINISH - when sweep finished successfully
Prints usual attachment info, transaction counters at the sweep finish moment and performance counters:

2012-06-26T14:17:28.1540 (3408:03828510) SWEEP_FINISH
EMPLOYEE.FDB (ATT_15285, SYSDBA:NONE, NONE, XNET:W2K3-X64)
firebird\bin\gfix.exe:3516

Transactions counters:
Oldest interesting 29420
Oldest active 29419
Oldest snapshot 29419
Next transaction 29421
24 ms, 159 read(s), 10 write(s), 5365 fetch(es), 133 mark(s)

c) SWEEP_FAILED - when sweep process was failed (due to shutdown or on-disk error, etc)
Prints usual attachment info and performance counters. Transaction counters are not printed.

Note: failure reason is not printed, use log_errors parameter to obtain this info.

d) SWEEP_PROGRESS - put after processing of every non-empty relation
Prints usual attachment info and performance counters. Performance stats is reset after beign printed to
allow see separate stats for every relation (i.e. stats in this event is not accumulated during whole sweep
process) :

2012-06-26T14:17:28.1540 (3408:03828510) SWEEP_PROGRESS
EMPLOYEE.FDB (ATT_15285, SYSDBA:NONE, NONE, XNET:W2K3-X64)
firebird\bin\gfix.exe:3516
0 ms, 2 read(s), 49 fetch(es)

Table Natural Index Update Insert Delete Backout Purge Expunge
***************************************************************************************************************
DEPARTMENT 21

2012-06-26T14:17:28.1540 (3408:03828510) SWEEP_PROGRESS
EMPLOYEE.FDB (ATT_15285, SYSDBA:NONE, NONE, XNET:W2K3-X64)
firebird\bin\gfix.exe:3516
3 ms, 7 read(s), 1 write(s), 484 fetch(es), 129 mark(s)

Table Natural Index Update Insert Delete Backout Purge Expunge
***************************************************************************************************************
RDB$FORMATS 1
EMPLOYEE 42 42

Note: some metadata related activity could be present at stats.

Common notes:
- all sweep events are put before ATTACH_DATABASE event.
- auto-triggered sweep could be distinguished from manual-started sweep by user name at attachment info.
For auto-triggered sweep it will be SWEEPER.

[firebird-automations]

Commented by: Thomas Steinmaurer (tsteinmaurer)

Very, very nice! Thanks for implementing this feature request!

[firebird-automations]

Modified by: @cincuranet

Link: This issue relate to DNET451 [ DNET451 ]

[firebird-automations]

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

[firebird-automations]

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

[firebird-automations]

Modified by: @pavel-zotov

QA Status: No test

[firebird-automations]

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Covered by another test(s)

Test Details: See tests for CORE4337 and CORE3934