Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isc_dsql_exec_immed2() loses input parameter value with RETURNING clause [CORE3730] #4076

Closed
firebird-issue-importer opened this issue Jan 15, 2012 · 17 comments

Comments

@firebird-issue-importer

Submitted by: @jasonwharton

Attachments:
ExecuteImmed2_InsertWithReturningClause.zip

A value passed in to insert a record is lost when the RETURNING clause is used via the EXECUTE IMMEDIATE api call isc_dsql_exec_immed2().

Commits: 9c035fe fd4bdc7 04401c2 dc4e08a

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 15, 2012

Commented by: @jasonwharton

This is a simple app that will cause the error to manifest.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 15, 2012

Modified by: @jasonwharton

Attachment: ExecuteImmed2_InsertWithReturningClause.zip [ 12085 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 16, 2012

Commented by: @jasonwharton

I neglected to mention, I have one of the later daily builds of 2.5.2 installed on a 64 bit Win7 machine.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Commented by: @jasonwharton

I would like to BUMP this issue a bit as it is really holding back a lot of customers and creating problems because this is the most efficient way to perform operations my component set needs. I have had others download the sample app and confirm there is indeed a problem in Firebird.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Modified by: @dyemanov

Component: Engine [ 10000 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Modified by: @dyemanov

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Commented by: @dyemanov

It has nothing to do with the RETURNING clause per se, it should affect any statement that has both input and output parameters and being executed via isc_dsql_exec_immed2(). And this bug seems to be pretty old (inherited from InterBase). The embedded server should work correctly, BTW, as the bug resides inside the remote server code.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Commented by: @jasonwharton

Interesting. I have had a history of problems with this API call. Hopefully now with your attention drawn to it you can get things tidied up. I have been waiting a LONG time to be able to rely on this API call.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Modified by: @dyemanov

Version: 2.5.1 [ 10333 ]

Version: 2.1.4 [ 10361 ]

Version: 2.5.0 [ 10221 ]

Version: 2.0.6 [ 10303 ]

Version: 3.0 Initial [ 10301 ]

Version: 2.1.3 [ 10302 ]

Version: 2.1.2 [ 10270 ]

Version: 2.0.5 [ 10222 ]

Version: 2.1.1 [ 10223 ]

Version: 2.1.0 [ 10041 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Commented by: @dyemanov

I have committed a fix into v2.5.2, so please test the next (tomorrow's) snapshot build and report back. Your test case now works without errors, but I'm pretty sure you have other interesting examples to try as well.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Modified by: @dyemanov

status: In Progress [ 3 ] => Open [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 17, 2012

Commented by: @jasonwharton

Will do! Thank you.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 18, 2012

Commented by: @jasonwharton

I tested this and it indeed appears to be resolved. THANK YOU!

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 24, 2012

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.0.7 [ 10390 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

Fix Version: 2.1.5 [ 10420 ]

Fix Version: 2.5.2 [ 10450 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Mar 27, 2014

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment