Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GBak does not check correctly parameters and backups random database with -B ":" [CORE3875] #4212

Closed
firebird-issue-importer opened this issue Jun 22, 2012 · 14 comments

Comments

@firebird-issue-importer

Submitted by: Semi (semi)

Given command:
"C:\Program Files\Firebird\Firebird_2_0\bin\gbak.exe" -T -B ":" "C:\Backup\BackupFileName.FBK" -v
the gbak 2.0.4 picks up some database for backup instead of giving error report.

Having this as a daily backup (due to batch error), it picked up different databases on different days...

Usual output is:
gbak: ERROR:file is not a valid database
gbak:Exiting before completion due to errors

Sometimes it writes:
gbak: ERROR:I/O error for file "MyDatabaseName
?"
gbak: ERROR: Error while trying to open file

(where the ? is char #⁠04)

In cca 1/10 cases it had backed up some database...
It probably happens only, if another program has a database opened...? It also backed up the database after some time the last program, that had it opened, has terminated... (as detected from my logs)

Test batch:

@echo off

:retry

"C:\Program Files\Firebird\Firebird_2_0\bin\gbak.exe" -T -B ":" "C:\Backup\test.fbk" -v
if errorlevel 1 goto retry

During running this batch, other program starting or terminating sometimes triggers this...
Using -B "localhost:" also sometimes triggers this error...

Commits: 23016b7 74c282b dbe4674

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Commented by: @AlexPeshkoff

I do not see how this can affect windows builds, but that probably requires more checks

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Modified by: @AlexPeshkoff

Fix Version: 3.0 Alpha 1 [ 10331 ]

Fix Version: 2.5.3 [ 10461 ]

Fix Version: 2.1.6 [ 10460 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Commented by: @AlexPeshkoff

Semi, please try (after 2 or days) with snapshot build of 2.1 or 2.5 to make sure did I fix your problem completely.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Commented by: @sim1984

Fix Version/s: 3.0 Alpha 1, 2.5.3, 2.1.6
Why not 2.5.2?

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Commented by: Sean Leyne (seanleyne)

v2.5.2 has already reach the RC stage, no new bug fixes should be added now.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Modified by: @dyemanov

Fix Version: 2.5.2 [ 10450 ]

Fix Version: 2.5.3 [ 10461 ] =>

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Commented by: @dyemanov

Sean, 2.5.2 is not at RC yet, although very close. And technically speaking, Alex has committed the patch into v2.5.2, as this version does not have a tag fork yet. So it will be available in v2.5.2.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 27, 2012

Commented by: Sean Leyne (seanleyne)

Obviously, I stand corrected.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 11, 2012

Commented by: @dyemanov

Alex, shouldn't we resolve this ticket?

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 12, 2012

Commented by: @AlexPeshkoff

I was waiting for people to check it on windows. If it's OK - resolve it please.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 12, 2012

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Apr 23, 2013

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants