Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API should return proper metadata properties, not the historical artifacts [CORE4178] #4504

Closed
firebird-issue-importer opened this issue Aug 12, 2013 · 9 comments

Comments

@firebird-issue-importer

Submitted by: @dyemanov

Attachments:
t4178.cpp
test4178.sql
test4178.sql

Instead of returning implementation details and keeing the old API weirdness, let's provide a clear implementation in IMessageMetadata. Now, for SQL_BLOB (subtype TEXT), getScale() returns a charset. For SQL_VARYING, getSubType() returns a charset, getCharSet() returns zero (accordingly to user reports). This makes the interface hardly usable and plays against the long-term success of the new API.

The fact that the old API emulation is stacked on top of the new API (thus possibly requiring a conversion between proper and legacy property values) could be a problem here, but it must be solved.

Commits: 2ab67b5 FirebirdSQL/fbt-repository@cf28250

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 12, 2013

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 3, 2013

Modified by: @dyemanov

Fix Version: 3.0 Beta 1 [ 10332 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 19, 2013

Modified by: @AlexPeshkoff

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 20, 2013

Commented by: @AlexPeshkoff

Database with a table with various fields and a program to display metadata properties for them

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 20, 2013

Modified by: @AlexPeshkoff

Attachment: t4178.cpp [ 12387 ]

Attachment: test4178.sql [ 12388 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 22, 2013

Modified by: @AlexPeshkoff

Attachment: test4178.sql [ 12389 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 22, 2013

Modified by: @AlexPeshkoff

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 2 [ 10560 ]

Fix Version: 3.0 Beta 1 [ 10332 ] =>

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 27, 2014

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants