Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve comments for output parameters after altering procedures [CORE4210] #4535

Closed
firebird-issue-importer opened this issue Sep 6, 2013 · 12 comments

Comments

@firebird-issue-importer
Copy link

firebird-issue-importer commented Sep 6, 2013

Submitted by: Vladimir Arkhipov (arkinform)

Is related to QA607

Сontinuation of CORE3140. After fixing does not work for output parameters. For input parameters description is preserved.

Commits: 58804e7 FirebirdSQL/fbt-repository@a31da6b

====== Test Details ======

Confirmed for 2.5.0...2.5.2: lost comments for some arguments.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Commented by: @asfernandes

Cannot reproduce:

SQL> create or alter procedure p1 (i integer) returns (o integer) as begin end;
SQL> comment on parameter p1.i is 'input';
SQL> comment on parameter p1.o is 'output';
SQL> show comments;
COMMENT ON PARAMETER P1.I IS input;
COMMENT ON PARAMETER P1.O IS output;
SQL> alter procedure p1 (i integer) returns (o integer) as begin end;
SQL> show comments;
COMMENT ON PARAMETER P1.I IS input;
COMMENT ON PARAMETER P1.O IS output;

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Commented by: Vladimir Arkhipov (arkinform)

The problem is reproduced when I use domains or type of column for parameters.
Comments for parameters with simple types (like integer) is preserved.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Commented by: @asfernandes

What I see is this, when an input parameter is changed to output, the comment is lost:

SQL> alter procedure p1 (o integer) returns (i integer) as begin end;
SQL> show comments;
COMMENT ON PARAMETER P1.O IS output;

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Commented by: @asfernandes

I found problem in 2.5, but are you sure there is still problem in v3-alpha1?

If yes, please send a valid test case.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Commented by: Vladimir Arkhipov (arkinform)

Sorry, I did not test it again on Firebird 3.0 Alpha 1, remove this version from issue.
But on Firebird 2.5 the problem is reproduced when I use domains or type of column for parameters.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Commented by: @asfernandes

Please test the fix in the next 2.5 snapshot build.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.3 [ 10461 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 6, 2013

Modified by: @asfernandes

Version: 3.0 Alpha 1 [ 10331 ] =>

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 10, 2013

Commented by: Vladimir Arkhipov (arkinform)

Works fine, thank you.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 28, 2015

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Done successfully

Test Details: Confirmed for 2.5.0...2.5.2: lost comments for some arguments.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 25, 2015

Modified by: @pcisar

Link: This issue is related to QA607 [ QA607 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment