Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call setlocale(LC_CTYPE, "") in isql for Windows [CORE4259] #4583

Closed
firebird-issue-importer opened this issue Nov 11, 2013 · 13 comments
Closed

Comments

@firebird-issue-importer

Submitted by: @aafemt

Assigned to: Frank Schlottmann-Goedde (fsg)

It breaks usual chcp work.

Commits: 9f235c2 bb54414 FirebirdSQL/fbt-repository@02b1f1a FirebirdSQL/fbt-repository@64e3530

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 11, 2013

Modified by: Frank Schlottmann-Goedde (fsg)

assignee: Frank Schlottmann-Goedde [ fsg ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 16, 2013

Commented by: Frank Schlottmann-Goedde (fsg)

Fixed with Rev. 58796

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 16, 2013

Modified by: Frank Schlottmann-Goedde (fsg)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 2 [ 10560 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 16, 2013

Commented by: @aafemt

This fix is wrong, IMHO.

Proposed fix:
#⁠if !defined(WIN_NT) && (defined(HAVE_EDITLINE_H) || defined(HAVE_LOCALE_H))

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 16, 2013

Commented by: Frank Schlottmann-Goedde (fsg)

Should be enough to check for HAVE_EDITLINE_H and HAVE_LOCALE, we don't have editline under Windows.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 27, 2014

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 17, 2014

Commented by: @aafemt

Someone added another call to setlocale() into ISQL_main() thus resurrecting the bug. Remove it, please.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 17, 2014

Modified by: @aafemt

status: Closed [ 6 ] => Reopened [ 4 ]

Fix Version: 3.0 Beta 2 [ 10586 ]

resolution: Fixed [ 1 ] =>

Fix Version: 3.0 Alpha 2 [ 10560 ] =>

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 17, 2014

Commented by: @dyemanov

"Someone" added setlocale() into ISQL_main() in May 2012 into both v2.5 and 3.0. This ticket was claimed as fixed after that. So it seems that:

- somebody added the second setlocale() into main() after that (only in 3.0)
- then, the second call was disabled for Windows
- then, you didn't (and nobody else did) test this bugfix after resolving

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 18, 2014

Modified by: @dyemanov

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 22, 2015

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 25, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant