You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
LibreOffice embeds FireBird, telling it to use a subdirectory of the LibreOffice tempdir for the firebird lockdir.
At process shutdown, ~Cleanup from file init.cpp is called, which calls this stack:
However, the LibreOffice temporary directory, which is the parent of the firebird lockdir, has been deleted by then, which causes the mkdir() to fail, throwing an exception that eventually causes (in development build) firebird to call abort().
So we changed LibreOffice to call fb_shutdown(0, 1) when it does not need firebird anymore, expecting that then ~Cleanup would not be called, or become a noop or ... We checked that fb_shutdown is actually called, and returns success. However, ~Cleanup still tries to do work, for that to create a lockdir, which fails and abort().
Please make fb_shutdown() make all the cleanups so that nothing is done at process exit() time anymore.
It's rather problematic to do nothing in ~Cleanup - it's a place in code where dtors of global objects are executed, and this should be done at exit time or when dynamic library is unloaded. Certainly attempts to create files/directories at this moment are absolutely wrong - and this is what I've fixed here.
I do not have access to Mac and therefore to test the fix compiled it on linux using set of system calls used/present on Mac. Everything looks fine but if you have any problems on real build - feel free to contact.
In principle, it can be tested:
* use a _debug_ build of Firebird
* start a firebird instance, opening a database, do some work
* call fb_shutdown(0, 1)
* rm -rf /path/to/fb_lockdir
* exit(0) the process or unload the firebird dynamic library
If the process aborts, the test failed. If it exits cleanly, the test succeeded.
Hard to do with our automated CI framework. We don't test debug builds and we don't test embedded alone. Also, I doubt we can call fb_shutdown() from Python. The comment was about adding a test to the regression suite.