Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to load provider/plugin not reported, anywhere [CORE4478] #4798

Closed
firebird-issue-importer opened this issue Jun 30, 2014 · 12 comments
Closed

Comments

@firebird-issue-importer

Submitted by: @aafemt

If a plugin cannot be loaded, there is no information about it anywhere. Even if the plugin is a mission-critical security-related one. IMHO, there must be a way to configure a plugin as a "must work one" and the engine must raise error if such plugin failed to load.

Commits: 2b066db FirebirdSQL/fbt-repository@acef6a6

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 30, 2014

Commented by: Sean Leyne (seanleyne)

Restated the Summary for better reading

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 30, 2014

Modified by: Sean Leyne (seanleyne)

summary: No feedback from a provider failed to load => Failure to load provider/plugin not reported, anywhere

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 1, 2014

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 1, 2014

Commented by: @AlexPeshkoff

I like an idea of adding configuration info to distinguish required and not-required plugins. But may be better mark plugins that may be not loaded? Currently I know only one in default configuration - engine12 in client case. When adding non-default entries mentioning in them not-required plugins will be possible but hardly needed.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 4, 2014

Commented by: @AlexPeshkoff

Added parameter Required to plugins configuration. Sample - section in plugins.conf

Plugin = Engine12 {
Required = Yes
}

will make plguin manager raise an error when module for this plugin is missing.

When module is bad (empty, invalid format, etc.) error is reported always no matter of Required value.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 4, 2014

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Beta 1 [ 10332 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 4, 2014

Commented by: @aafemt

What is default value for this parameter?

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 6, 2014

Commented by: @AlexPeshkoff

false

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jul 26, 2014

Commented by: @aafemt

"true" would be better. With "false" users will have a hard time looking for a mistype in pligin's name.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 23, 2015

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 18, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 25, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants