Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submitted by: @ibprovider
jrd.cpp, GDS_DROP_DATABASE
for (; shadow; shadow = shadow->sdw_next) { err = err || drop_files(shadow->sdw_file); //<---- mistake? }
I think, this code should be written like this:
for (; shadow; shadow = shadow->sdw_next) { if ( drop_files(shadow->sdw_file) ) err=true; }
?
Commits: 395e1aa FirebirdSQL/fbt-repository@ad6e38a
The text was updated successfully, but these errors were encountered:
Commented by: @dyemanov
Maybe the idea was to stop dropping shadows after the first failure encountered?
Sorry, something went wrong.
priority: Major [ 3 ] => Trivial [ 5 ]
Fix Version: 2.5.4 [ 10585 ]
Commented by: @hvlad
The fix was made in fb3 almost a year ago. Backported.
status: Open [ 1 ] => Resolved [ 5 ]
resolution: Fixed [ 1 ]
status: Resolved [ 5 ] => Resolved [ 5 ]
QA Status: Cannot be tested
status: Resolved [ 5 ] => Closed [ 6 ]
No branches or pull requests
Submitted by: @ibprovider
jrd.cpp, GDS_DROP_DATABASE
for (; shadow; shadow = shadow->sdw_next)
{
err = err || drop_files(shadow->sdw_file); //<---- mistake?
}
I think, this code should be written like this:
for (; shadow; shadow = shadow->sdw_next)
{
if ( drop_files(shadow->sdw_file) )
err=true;
}
?
Commits: 395e1aa FirebirdSQL/fbt-repository@ad6e38a
The text was updated successfully, but these errors were encountered: