Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in GDS_DROP_DATABASE? [CORE4700] #5008

Closed
firebird-issue-importer opened this issue Feb 26, 2015 · 6 comments
Closed

Mistake in GDS_DROP_DATABASE? [CORE4700] #5008

firebird-issue-importer opened this issue Feb 26, 2015 · 6 comments

Comments

@firebird-issue-importer

Submitted by: @ibprovider

jrd.cpp, GDS_DROP_DATABASE

for (; shadow; shadow = shadow->sdw_next)
{
err = err || drop_files(shadow->sdw_file); //<---- mistake?
}

I think, this code should be written like this:

for (; shadow; shadow = shadow->sdw_next)
{
if ( drop_files(shadow->sdw_file) )
err=true;
}

?

Commits: 395e1aa FirebirdSQL/fbt-repository@ad6e38a

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 26, 2015

Commented by: @dyemanov

Maybe the idea was to stop dropping shadows after the first failure encountered?

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 26, 2015

Modified by: @hvlad

priority: Major [ 3 ] => Trivial [ 5 ]

Fix Version: 2.5.4 [ 10585 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 26, 2015

Commented by: @hvlad

The fix was made in fb3 almost a year ago. Backported.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 26, 2015

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 30, 2015

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Cannot be tested

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Sep 23, 2015

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant