Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providers enumeration should not be continued on most of errors taking place in the provider [CORE4911] #5203

Closed
firebird-issue-importer opened this issue Aug 18, 2015 · 4 comments

Comments

@firebird-issue-importer

Submitted by: @AlexPeshkoff

Most of errors, taking place in providers, are fatal, and there is no use trying other providers when such errors take place.
For example, if remote redirector detected that format of database connection string matches some protocol, it's no use trying other providers if connection on that protocol failed. Or when engine reported some internal database error (except invalid ODS version) it's no use trying to open that database with loopback provider.

It seems that it's better to enumerate error codes after which trying other providers makes sense - that's first of all isc_unavailable and isc_no_priv, but due to historical reasons (content of status vector for known conditions should be kept as it was) adding some more error codes is needed.

Commits: b658497 FirebirdSQL/fbt-repository@f780e5d

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 18, 2015

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Aug 18, 2015

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 RC 1 [ 10584 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 23, 2015

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 25, 2016

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment