Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISQL: add warning / error message when script contains several 'IN' commands without delimiter (semicolon) between them [CORE4948] #5239

Open
firebird-issue-importer opened this issue Sep 30, 2015 · 0 comments

Comments

@firebird-issue-importer

Submitted by: @pavel-zotov

1) create new database
2) create three .sql files:
`f1.sql` - with single command like: recreate table test1(id int);
`f2.sql` - with similar command but for another table: recreate table test2(id int);
`f3.sql` - similar to `f2.sql` but for table 'test3'.

3) create "main" script, let its name will be 'fm.sql', with content:

set echo on;
in f1.sql
in f2.sql
in f3.sql
commit;
show table;

or with such:

set echo on;
in f1.sql in f2.sql in f3.sql
commit;
show table;

NOTE: there is NO delimiter (semicolon) between "IN" statements.

Than run isql and look at result:

C:\FBTESTING\qa\fbt-repo\tmp>isql /3333:e30 -i fm.sql 1>log 2>err

C:\FBTESTING\qa\fbt-repo\tmp>type log
in f1.sql in f2.sql in f3.sql
commit;
recreate table test1(id int);
show table;
TEST1

C:\FBTESTING\qa\fbt-repo\tmp>dir err | findstr /i /c:"err"
30.09.2015 01:13 0 err

No alerts and only one table has been created.
I'm not sure that this is a bug because "IN" command does not belong to DML/DDL set.
But ISQL should produce at least warning about scripts that were SKIPPED from execution.

(when script is typing by programmer this delimiter missing can be easy noted; but this will be difficult task when some complicated script is generated by *another* command scenario (.bat / .sh) which contains such 'small' error like mentioned above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant