Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer includes malformed strings [CORE5002] #5290

Closed
firebird-issue-importer opened this issue Nov 9, 2015 · 10 comments
Closed

Comments

@firebird-issue-importer
Copy link

firebird-issue-importer commented Nov 9, 2015

Submitted by: Mykhaylo Masyk (miwa)

Attachments:
1.png
FB3rc_inst_locale.png
FB3rc_inst_locale_1.png
FB3rc_inst_locale_2.png

During installation FB3RC1 in Win7 using Russian language one can see malformed messages (for instance on the "Select tasks" step, but not only in it) in the installer. In particular, all English messages looks properly, however all Russian messages look like on image available at http://www.sql.ru/forum/actualfile.aspx?id=18392603

Commits: 29baa78 a8e163b FirebirdSQL/fbt-repository@0fd9c6a FirebirdSQL/fbt-repository@64375e1

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 10, 2015

Modified by: @dyemanov

issuetype: Improvement [ 4 ] => Bug [ 1 ]

assignee: Paul Reeves [ paul_reeves ]

description: During installation FB3RC1 in Win7 using russian language one can see malformed messages (for instance on the "Select tasks" step, but not only in it) in the installer. In particular, all English messages looks properly, however all Russian messages look like on image available at http://www.sql.ru/forum/actualfile.aspx?id=18392603 => During installation FB3RC1 in Win7 using Russian language one can see malformed messages (for instance on the "Select tasks" step, but not only in it) in the installer. In particular, all English messages looks properly, however all Russian messages look like on image available at http://www.sql.ru/forum/actualfile.aspx?id=18392603

security: Developers [ 10012 ] =>

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 10, 2015

Commented by: @reevespaul

Could you upload an image to the tracker please? I can't get access to the link you provided.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 10, 2015

Modified by: @dyemanov

Attachment: 1.png [ 12846 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 10, 2015

Commented by: @dyemanov

Attached.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 10, 2015

Commented by: @reevespaul

OK. I think I understand the problem. The translated custom messages were written for an older version of InnoSetup. Everything back then was in ansi. InnoSetup now provides two compilers - one for Unicode and one for old ansi support. I think it makes sense to use the Unicode one for Firebird 3. And I suspect the problem we are seeing will be resolved by converting the custom_messages file to unicode.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 10, 2015

Commented by: Arioch (arioch)

More examples ( win7 x64 rus / fb3rc1 x64 ).

1st screen is the warning about other FB versions running, before the main Welcome screen.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 10, 2015

Modified by: Arioch (arioch)

Attachment: FB3rc_inst_locale.png [ 12847 ]

Attachment: FB3rc_inst_locale_1.png [ 12848 ]

Attachment: FB3rc_inst_locale_2.png [ 12849 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 28, 2016

Commented by: @reevespaul

It seems that the problem was fixed by a) converting the text to UTF-8 and b) adding the BOM. For some reason InnoSetup gets confused if the BOM is missing.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 28, 2016

Modified by: @reevespaul

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 RC2 [ 10048 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 2, 2016

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants