Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbak with invalid parameter crashes FB [CORE5068] #5355

Closed
firebird-issue-importer opened this issue Jan 6, 2016 · 8 comments
Closed

gbak with invalid parameter crashes FB [CORE5068] #5355

firebird-issue-importer opened this issue Jan 6, 2016 · 8 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Jan 6, 2016

Submitted by: @WarmBooter

Typo in gbak's command line parameter causes Firebird process to crash, ie:

gbak -c -v -se service_mgr -user_all_space d:\backup.gbk d:\bd.fdb
gbak:unknown switch "USER_ALL_SPACE"
gbak: ERROR:connection lost to database
gbak:Exiting before completion due to errors

Commits: 95d187c FirebirdSQL/fbt-repository@b2e33a2

====== Test Details ======

Confirmed crash on 2.5.5.26952, but only when use 'gbak' utility (with services call).
As of fbsvcmgr, it works correct and reports error: Unknown switch "res_user_all_space".
Output when use gbak is:
gbak:unknown switch "USER_ALL_SPACE"
gbak: ERROR:Unable to complete network request to host "localhost".
gbak: ERROR: Error reading data from the connection.
gbak:Exiting before completion due to errors

Checked on WI-V2.5.6.26962 - works OK.
No test needed for 3.0 thus only stub code present here in 'firebird_version': '3.0' section.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 6, 2016

Modified by: @WarmBooter

Component: Engine [ 10000 ]

Component: GBAK [ 10006 ]

Loading

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 6, 2016

Commented by: Claudio Valderrama C. (robocop)

Can't reproduce:

gbak -c -v -se service_mgr -user_all_space d:\backup.gbk d:\bd.fdb
gbak: ERROR:Cannot attach to services manager
gbak: ERROR: user name and password are required while attaching to the services manager
gbak:Exiting before completion due to errors

gbak -c -v -se service_mgr -user_all_space d:\backup.gbk d:\bd.fdb -user sysdba -pass masterkey
gbak:unknown switch "USER_ALL_SPACE"
gbak:Usage:
gbak -b <db set> <backup set> [backup options] [general options]
[snip]

isql based.fdb -z -user sysdba -pass masterkey
ISQL Version: WI-V2.5.5.26942 Firebird 2.5
Server version:
WI-V2.5.5.26942 Firebird 2.5
WI-V2.5.5.26942 Firebird 2.5/XNet (ATENEA)/P12
WI-V2.5.5.26942 Firebird 2.5/XNet (ATENEA)/P12
Database: based.fdb, User: sysdba
SQL>

Loading

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 6, 2016

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

Loading

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 6, 2016

Commented by: @hvlad

The bug was introduced in build 26948 by my commit

Revision: 62434
Author: hvlad
Date: 27 October 2015 г. 13:20:18
Message:
Backport feature CORE1999 : TimeStamp in the every line output gbak.exe utility

It was sad typo when backporting

Loading

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 6, 2016

Commented by: @hvlad

Bug happens only when backup\restore is made using services and when wrong switch is passed.

Loading

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 6, 2016

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.6 [ 10721 ]

Loading

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 8, 2016

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

Test Details: Confirmed crash on 2.5.5.26952, but only when use 'gbak' utility (with services call).
As of fbsvcmgr, it works correct and reports error: Unknown switch "res_user_all_space".
Output when use gbak is:
gbak:unknown switch "USER_ALL_SPACE"
gbak: ERROR:Unable to complete network request to host "localhost".
gbak: ERROR: Error reading data from the connection.
gbak:Exiting before completion due to errors

Checked on WI-V2.5.6.26962 - works OK.
No test needed for 3.0 thus only stub code present here in 'firebird_version': '3.0' section.

Loading

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jan 8, 2016

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants