Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide method to correcty set offsets in implemented by user IMessageMetadata [CORE5083] #5369

Closed
firebird-issue-importer opened this issue Jan 25, 2016 · 6 comments

Comments

@firebird-issue-importer

Submitted by: @AlexPeshkoff

For correct operation of firebird interface offsets of fields in messages should be set in some strict way, defined by engine.
Users should have a way to correctly set offsets if they want to define metadata interface themself.

Commits: ffa487a FirebirdSQL/fbt-repository@5eda59c

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 25, 2016

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 25, 2016

Commented by: @AlexPeshkoff

Added method setOffsets() to utilities interface.
Minimal sample of user-implemented IMessageMetadata added to interface examples.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 25, 2016

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 RC2 [ 10048 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 25, 2016

Commented by: @aafemt

IMHO, on contrary, users should be able to provide offsets they like and engine must accept them.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 26, 2016

Commented by: @AlexPeshkoff

May be sometimes in the future we will have an API making it possible to have arbitrary messages format.
But for today this is a compromise between ideal and real.

As long as we keep messages in API this call will be ayway useful if somebody does not want to care about offsets himself.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 2, 2016

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants