Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the Linux code with --enable-binreloc and create an option in the installer to install in different locations than /opt/firebird [CORE5204] #5485

Closed
firebird-issue-importer opened this issue Apr 22, 2016 · 16 comments

Comments

@firebird-issue-importer

Submitted by: @asfernandes

Relate to CORE5724

Commits: 383c511 bddc876 4c28eac 6d7e4d9 b994354 1d2990f

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Apr 22, 2016

Commented by: @AlexPeshkoff

Adriano, want to make sure - do you plan to make changes in installer yourself or want me to do it?

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Apr 22, 2016

Modified by: @AlexPeshkoff

Fix Version: 3.0.1 [ 10730 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Apr 22, 2016

Commented by: @asfernandes

I was not planing to do it myself, at least not right now.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Apr 22, 2016

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 10, 2016

Commented by: @asfernandes

Alex, it would be good to have options to:

- Set an instance name to put in init scripts

- Install just the embedded, without init scritps

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 10, 2016

Commented by: @AlexPeshkoff

Multi-instance support is probably good and useful thing, but I do not think it should be done this way, i.e. reinstalling with parameters or dialog options.
We must not forget about silent install that is used by most of distro-specific packages (if not all).
I.e. to support multiple instances I prefer a separate script controlling instances: create & drop support.

What about embedded install - well, why not.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented May 10, 2016

Commented by: @asfernandes

"create an option in the installer to install in different locations than /opt/firebird" with non-embedded installation will destroy previous installations (in other directories) init scripts...

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 15, 2016

Commented by: @AlexPeshkoff

Implemented -path option in installer script.

Install into non-default path is always treated as 'secondary' install with following limitations:
- links to .h files in /usr/include and libraries in /usr/lib are not created in order not to overwrite primary firebird installation
- init.d or xinetd startup files are created with a name posfixed with installation path (if one uses -path /usr/local/fb4 startup file is named firebird.usr_local_fb4)
- services are disabled by default (i.e. user must start /etc/init.d service manually or enable xinetd service manually)

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 15, 2016

Commented by: @asfernandes

Shouldn't --enable-binreloc be used by default?

Otherwise the install directory will be detected as FB_PREFIX (/opt/firebird).

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 15, 2016

Modified by: @pavel-zotov

status: Open [ 1 ] => Open [ 1 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 15, 2016

Commented by: @AlexPeshkoff

By default - no, this can break distro specific builds when utilities go to /usr/bin, server - to /usr/sbin, etc.
But you are right - presence of binreloc should be detected and in absense of it switch -path should be disabled.

BTW, I've added this switch to snapshot build.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 19, 2016

Modified by: @AlexPeshkoff

Fix Version: 3.0.2 [ 10785 ]

Fix Version: 3.0.1 [ 10730 ] =>

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Sep 19, 2016

Modified by: @AlexPeshkoff

Fix Version: 4.0 Alpha 1 [ 10731 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 21, 2016

Commented by: @AlexPeshkoff

Added to http://install.sh switch -path to specify non-default install path

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Nov 21, 2016

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 26, 2018

Modified by: @AlexPeshkoff

Link: This issue relate to CORE5724 [ CORE5724 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants