Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly defined names for NOT NULL constraints are not exported into script by ISQL -x [CORE5218] #5498

Closed
firebird-automations opened this issue Apr 28, 2016 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @dyemanov

create table t (
id int constraint tc0 primary key,
col1 int constraint tc1 unique,
col2 int constraint tc2 not null,
col3 int not null);

Then export via isql -x:

/* Table: T, Owner: DIMITR */
CREATE TABLE T (ID INTEGER NOT NULL,
COL1 INTEGER,
COL2 INTEGER NOT NULL,
COL3 INTEGER NOT NULL,
CONSTRAINT TC0 PRIMARY KEY (ID),
CONSTRAINT TC1 UNIQUE (COL1));

Both COL2 and COL3 are exported with unnamed NOT NULL constraints, despite the explicitly specified name TC2. The funny thing is that it gets exported correctly for Dialect 1 databases but not for Dialect 3 databases. The script should be something like:

/* Table: T, Owner: DIMITR */
CREATE TABLE T (ID INTEGER NOT NULL,
COL1 INTEGER,
COL2 INTEGER CONSTRAINT TC2 NOT NULL,
COL3 INTEGER NOT NULL,
CONSTRAINT TC0 PRIMARY KEY (ID),
CONSTRAINT TC1 UNIQUE (COL1));

Commits: 16766f1 2d7261c c88f659

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Component: ISQL [ 10003 ]

Component: Engine [ 10000 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

summary: Explicitly defined names for NOT NULL constraint are not exported into script by ISQL -x => Explicitly defined names for NOT NULL constraints are not exported into script by ISQL -x

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.6 [ 10721 ]

Fix Version: 3.0.1 [ 10730 ]

Fix Version: 4.0 Alpha 1 [ 10731 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment