Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nested keys in plugin configuration [CORE5257] #5536

Closed
firebird-issue-importer opened this issue Jun 3, 2016 · 8 comments
Closed

Enable nested keys in plugin configuration [CORE5257] #5536

firebird-issue-importer opened this issue Jun 3, 2016 · 8 comments

Comments

@firebird-issue-importer
Copy link

@firebird-issue-importer firebird-issue-importer commented Jun 3, 2016

Submitted by: @hvlad

Config-parsing code already supports nested keys but this feature is explicitly disabled in code for more than one nesting level.
API also supports nested keys, see IConfigEntry::getSubConfig method.
It seems we could safely enable this feature (and there is users asking for it)

Example of nested keys (could be used in plugins.conf):

Config = MyPluginConfig {
Key1 = Val1
Key2 = Val2 {
SubKey = Val
Subkey2 = {
...
}
}
}

currently, such configuration is parsed as set of plain keys.

Commits: 25177b5 2825af9 11b0bf7 50447a5

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 3, 2016

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Jun 3, 2016

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0.1 [ 10730 ]

Fix Version: 4.0 Alpha 1 [ 10731 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 24, 2016

Commented by: @hvlad

Re-opened due to wrong parsing of nested keys

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 24, 2016

Modified by: @hvlad

status: Resolved [ 5 ] => Reopened [ 4 ]

Fix Version: 3.0.2 [ 10785 ]

resolution: Fixed [ 1 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 24, 2016

Commented by: @hvlad

Strongly speaking, wrong parsing of nested keys is a different issue, but enabling of not working code is a nonsense therefore i decided to not create new ticket.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 24, 2016

Modified by: @hvlad

Version: 3.0.1 [ 10730 ]

Fix Version: 3.0.1 [ 10730 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Oct 27, 2016

Modified by: @hvlad

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented May 25, 2017

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment