Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of SPB parameters fail in FB 3 & 4 [CORE5278] #5556

Closed
firebird-issue-importer opened this issue Jun 13, 2016 · 6 comments
Closed

Comments

@firebird-issue-importer

Submitted by: @cincuranet

Block progress on DNET653
Jira_subtask_outward CORE5379

Looking into CrumpletReader I see:
case isc_action_svc_backup:
case isc_action_svc_restore:
switch (tag)
{
case isc_spb_bkp_file:
case isc_spb_dbname:
case isc_spb_res_fix_fss_data:
case isc_spb_res_fix_fss_metadata:
case isc_spb_bkp_stat:
return StringSpb;
case isc_spb_bkp_factor:
case isc_spb_bkp_length:
case isc_spb_res_length:
case isc_spb_res_buffers:
case isc_spb_res_page_size:
case isc_spb_options:
case isc_spb_verbint:
return IntSpb;
case isc_spb_verbose:
return SingleTpb;
case isc_spb_res_access_mode:
return ByteSpb;
}
invalid_structure("unknown parameter for
backup/restore");
break;

No isc_spb_bkp_skip_data or isc_spb_res_skip_data there.

Commits: 0828aff 1c920ac

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 13, 2016

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 14, 2016

Modified by: @cincuranet

Link: This issue block progress on DNET653 [ DNET653 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 15, 2016

Commented by: @AlexPeshkoff

Except isc_spb_bkp_skip_data/ isc_spb_res_skip_data fail:

1. A set of *_64 parameters in gfix (isc_spb_rpr_commit_trans_64 and others) - not mentioned in switch table
2. isc_action_svc_properties - missing in UTF8 converter
3. isc_spb_sec_username used at non-first place when deleting user

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 15, 2016

Modified by: @AlexPeshkoff

Version: 4.0 Initial [ 10621 ]

summary: CrumpletReader is missing isc_spb_bkp_skip_data and isc_spb_res_skip_data => A number of SPB parameters fail in FB 3 & 4

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 15, 2016

Commented by: @AlexPeshkoff

A kind of services debugger added to DEV_BUILD - it checks for correct delivery of all service parameters, present in fbsvcmgr to engine. To use it run:
fbsvcmgr -@
Feature does not affect release build.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jun 15, 2016

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0.1 [ 10730 ]

Fix Version: 4.0 Alpha 1 [ 10731 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment