Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect processing (truncation) of SQL statement longer than 10MB [CORE5382] #5655

Closed
firebird-issue-importer opened this issue Oct 26, 2016 · 12 comments

Comments

@firebird-issue-importer

Submitted by: @ibprovider

Votes: 1

SQL Statement (total length = 10*1024*1024+1):

"select/*---------- .... ---------------*/ID from DUAL "

---------------
Prepare error:

Dynamic SQL Error
SQL error code = -204
Table unknown
DUA

---------------

1. I think, the error message must be a little another.

2. Special for this case, I created the new table "DUA" and server prepared original query without any problem.

Commits: b4448a9 af37a96 FirebirdSQL/fbt-repository@13fd176

====== Test Details ======

See fbt-repo\tests\bugs\isql_05.fbt

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2016

Commented by: @asfernandes

10 MB is the limit and the code truncates (by purpose) it.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2016

Modified by: @pavel-zotov

status: Open [ 1 ] => Open [ 1 ]

QA Status: No test => Covered by another test(s)

Test Details: See fbt-repo\tests\bugs\isql_05.fbt

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2016

Modified by: @pavel-zotov

status: Open [ 1 ] => Closed [ 6 ]

resolution: Fixed [ 1 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2016

Commented by: @ibprovider

Sorry, I not understood - FB source code was corrected or no?

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2016

Commented by: @dyemanov

Sorry, Pavel was too fast to resolve this ticket. The current behaviour is intended, but honestly, I don't remember why I decided to truncate instead of raising the error.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2016

Modified by: @dyemanov

status: Closed [ 6 ] => Reopened [ 4 ]

resolution: Fixed [ 1 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2016

Commented by: @dyemanov

Would there be any objections to replacing silent truncation with an explicit error?

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2016

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 4, 2016

Commented by: @asfernandes

> Would there be any objections to replacing silent truncation with an explicit error?

Not from me, I agree it should throw.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 8, 2016

Modified by: @dyemanov

Version: 3.0.1 [ 10730 ]

Version: 3.0.0 [ 10740 ]

Version: 4.0 Initial [ 10621 ]

summary: Incorrect processing (truncation) of SQL statement with length 10MB+1 => Incorrect processing (truncation) of SQL statement longer than 10MB

Version: 3.0.2 [ 10785 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 8, 2016

Modified by: @dyemanov

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Alpha 1 [ 10731 ]

Fix Version: 3.0.2 [ 10785 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 8, 2016

Commented by: @dyemanov

Fixed to raise an error instead of truncating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants