Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace duplicates asci_char(13) in its output (Windows only) [CORE5477] #5747

Closed
firebird-issue-importer opened this issue Feb 3, 2017 · 7 comments

Comments

@firebird-issue-importer
Copy link

firebird-issue-importer commented Feb 3, 2017

Submitted by: @pavel-zotov

Attachments:
trace-on-windows-duplicated-ascii-char-13.PNG

Checked this on last FB, but it seems that this bug lives from 2.5.0.
See attached file for illustration.

Commits: f6c3e5c 118b578 e3b24b1

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 3, 2017

Modified by: @pavel-zotov

Attachment: trace-on-windows-duplicated-ascii-char-13.PNG [ 13062 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 4, 2017

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 4, 2017

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.7 [ 10770 ]

Fix Version: 3.0.2 [ 10785 ]

Fix Version: 4.0 Alpha 1 [ 10731 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 7, 2017

Commented by: @pavel-zotov

WI-T4.0.0.530 - perfect! No more chr(13) dups, also one may see that names of tables are properly adjusted (this was lost about one year ago).

Vlad, thank you very much!

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 9, 2017

Commented by: @pavel-zotov

One minor remark.

For this config:

      enabled = true
      time\_threshold = 0
      log\_initfini   = false
      log\_connections = true

===

-- 1st line of trace (with message "Trace session ID NNN started") has EOL = only ascii_char(10) rather than pair of: chr(10) + chr(13).
And this is the only such line - all others have EOL = char(10) + chr(13).

This is only FYI.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 9, 2017

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Feb 9, 2017

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment