Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase number of formats/versions of views from 255 to 32K [CORE5647] #5913

Closed
firebird-issue-importer opened this issue Oct 23, 2017 · 11 comments

Comments

@firebird-issue-importer

Submitted by: Omacht András (aomacht)

Altering views has the same limit (maximum 255 versions) like tables.
As we discussed in Prague and privatly with Vlad it is a non-necessary limitation in Firebird.

Please remove this limitation.

Here is a test case how to reproduce the problem:

execute block
as
declare variable i integer;
begin
i = 1;
while (i < 300) do
begin
if (mod(i, 2) = 0) then
begin
in autonomous transaction do
begin
execute statement 'create or alter view vw1 (dump1) as select 1 from rdb$database';
end
end
else
begin
in autonomous transaction do
begin
execute statement 'create or alter view vw1 (dump1, dump2) as select 1, 2 from rdb$database';
end
end
i = i + 1;
end
end

Commits: 3dd6a2f

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2017

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

summary: Enable views to support unlimited multply formats / versions => Increase number of formats/versions of views from 255 to 32K

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2017

Modified by: @asfernandes

Version: 4.0 Alpha 1 [ 10731 ]

Version: 4.0 Beta 1 [ 10750 ] =>

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2017

Commented by: @asfernandes

Please test next snapshot version for v4, so we can see to backport the fix to v3.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 3, 2017

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 9, 2017

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 9, 2017

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@omachtandras
Copy link

@omachtandras omachtandras commented May 5, 2021

Hi!
Sorry for the later feedback.
It works fine on 4.0.0.2465, but failed on 3.0.8.33465
András

asfernandes added a commit that referenced this issue May 5, 2021
…5 to 32K (CORE-5647).
@gaborboros-bgss
Copy link

@gaborboros-bgss gaborboros-bgss commented May 5, 2021

Hi All,

And the tables? Are they play in a different league?

Gabor

@asfernandes
Copy link
Member

@asfernandes asfernandes commented May 5, 2021

Every record has a reference to the table's format used and this reference is a single byte, so it cannot be done without ODS change that will make all records bigger.

@omachtandras
Copy link

@omachtandras omachtandras commented May 5, 2021

Ok Adriano, thank you! It helps us much, we are altering views more offen than tables.

@omachtandras
Copy link

@omachtandras omachtandras commented May 6, 2021

3.0.8.33467 works fine too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment