Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace config with misplaced "{" lead firebird to crash [CORE5706] #5972

Closed
firebird-issue-importer opened this issue Jan 13, 2018 · 5 comments

Comments

@firebird-issue-importer

Submitted by: @pavel-zotov

Attachments:
gdb-trace-config-with-misplaced-opening-brace-crashes-firebird-process.txt.7z

1) create trivial trace config:
cat -n /opt/scripts/1trace.fb30.conf
1 database = (%[\\/](security3).fdb|(security.db))
2 enabled = false
3 {
4 }

NOTE: opening brace "{" is on wrong place (line #⁠3), it must be above "enabled = false" (line #⁠2)

2) launch trace (fbsvcmgr action_trace_start ...)

3) /opt/firebird/bin/isql localhost/3050:employee -q -user sysdba -pas masterkey
Statement failed, SQLSTATE = 08004
connection rejected by remote interface

Stack trace see in attached .7z

Commits: 3843328 37864b4

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 13, 2018

Modified by: @pavel-zotov

Attachment: gdb-trace-config-with-misplaced-opening-brace-crashes-firebird-process.txt.7z [ 13200 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 13, 2018

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 13, 2018

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0.3 [ 10810 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 16, 2018

Commented by: @pavel-zotov

I see one else (minor) problem. May be it relates to this ticket (?)

1) create following trace config:
database = (%[\\/](security[[:digit:]]).fdb|(security.db))
enabled = false
{
}
database =
{
enabled = true
log_connections = true
}

2) launch trace on FB 3.0.3 Classic (using this config)
3) launch in other window somewhat that force trace to work - i.e. connect to some DB or run 'fbsvcmgr action_trace_list'

You will see following:

1 Trace session ID 1 started
2 Error creating trace session for database "C:\MIX\FIREBIRD\FB30\SECURITY3.FDB":
3 error while parsing trace configuration
4 Trace parameters are not present
5 Error creating trace session for database "C:\MIX\FIREBIRD\FB30\SECURITY3.FDB":
6 error while parsing trace configuration
7 Trace parameters are not present

So, lines from 5 to 7 duplicate lines from 2 to 4.
This can be seen only in FB 3.0.3 Classic.
No such problem on SS, and also no problem on 4.0 (any arch.)

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Jan 16, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment