Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date-time parsing is very weak [CORE5750] #6013

Closed
firebird-issue-importer opened this issue Feb 16, 2018 · 5 comments
Closed

Date-time parsing is very weak [CORE5750] #6013

firebird-issue-importer opened this issue Feb 16, 2018 · 5 comments

Comments

@firebird-issue-importer

Submitted by: @asfernandes

Firebird date-time parser accepts non-standard separators, accepting (interpreting) wrong strings.

These are currently considered valid:

SQL> select timestamp '2018-01-01 10 20 30' from rdb$database;

             CONSTANT 

=========================
2018-01-01 10:20:30.0000

SQL> select timestamp '2018-01-01 10,20,30 40' from rdb$database;

             CONSTANT 

=========================
2018-01-01 10:20:30.4000

This is a problem when timezone is introduced, as the zone is separated from the time by a space.

Commits: 53be87c 4812ce8

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 16, 2018

Modified by: @asfernandes

Version: 3.0.3 [ 10810 ]

Version: 2.5.8 [ 10809 ]

Version: 4.0 Alpha 1 [ 10731 ]

Component: Engine [ 10000 ]

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Feb 20, 2018

Commented by: @asfernandes

Fixed in branch work/time-zone-support.

Date components separator may be a single one (first and second occurence): dash, slash or dot.

Time components (hours to minutes to seconds) separator may be colon.

Seconds to fractions separator may be dot.

There could not be any separator (other than spaces) between date and time.

Spaces are allowed before and after separator characters.

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Nov 27, 2018

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 5, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-issue-importer
Copy link
Author

@firebird-issue-importer firebird-issue-importer commented Apr 5, 2019

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants