Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server hangs when client tries to send too long DB encryption key(s) [CORE5780] #6043

Closed
firebird-issue-importer opened this issue Mar 19, 2018 · 6 comments

Comments

@firebird-issue-importer

Submitted by: @AlexPeshkoff

When client sends to the server more data than fits into single network packet used for such transfers async send fails.

Commits: 27a6c41 e5ec4f5

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 19, 2018

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 19, 2018

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

Fix Version: 3.0.4 [ 10863 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 19, 2018

Commented by: Sean Leyne (seanleyne)

Is the issue really about network "packet" (which is controlled by MTU settings -- default = 1500 bytes)? Or, about the size of the TCP buffer that FB allocates for sending/receiving msgs from the server?

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 20, 2018

Commented by: @AlexPeshkoff

About the size of the TCP buffer that FB allocates for sending/receiving msgs, i.e. TcpRemoteBufferSize.
But it does not matter for committed fix - as soon as server detects fragmented packet in async receiver it drops that attachment.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 25, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Mar 25, 2018

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment